Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 184483004: Reduce heavy runtime calls from debug mirrors. (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
ulan, rossberg, yurys, Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Reduce heavy runtime calls from debug mirrors. Cache results of some heavy calls into C++. This alone will boost the speed up to 18% on some real world scenarios. BUG=chromium:340285 LOG=Y R=ulan@chromium.org, yangguo@chromium.org, Yang, rossberg, ulan, yurys Committed: https://code.google.com/p/v8/source/detail?r=19714

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -30 lines) Patch
M src/mirror-debugger.js View 9 chunks +44 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aandrey
6 years, 9 months ago (2014-02-28 17:15:55 UTC) #1
aandrey
ping?
6 years, 9 months ago (2014-03-04 09:11:44 UTC) #2
ulan
Looks good overall, but I am not familiar with debug mirrors. Now that we cache ...
6 years, 9 months ago (2014-03-04 10:23:14 UTC) #3
aandrey
On 2014/03/04 10:23:14, ulan wrote: > Looks good overall, but I am not familiar with ...
6 years, 9 months ago (2014-03-04 10:46:13 UTC) #4
ulan
thanks, lgtm
6 years, 9 months ago (2014-03-04 10:51:25 UTC) #5
Yang
On 2014/03/04 10:51:25, ulan wrote: > thanks, lgtm lgtm.
6 years, 9 months ago (2014-03-04 11:14:26 UTC) #6
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 9 months ago (2014-03-04 12:35:54 UTC) #7
yurys
The CQ bit was unchecked by yurys@chromium.org
6 years, 9 months ago (2014-03-04 12:35:55 UTC) #8
ulan
6 years, 9 months ago (2014-03-07 10:25:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r19714 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698