Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: webrtc/p2p/quic/quicsession.cc

Issue 1844803002: Modify PeerConnection for end-to-end QuicDataChannel usage (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/quic/quicsession.cc
diff --git a/webrtc/p2p/quic/quicsession.cc b/webrtc/p2p/quic/quicsession.cc
index 281af5e3a745a254475f5c85b8d63949c8452384..9885771c259ff70ee6befe8b00792b1dfec8e311 100644
--- a/webrtc/p2p/quic/quicsession.cc
+++ b/webrtc/p2p/quic/quicsession.cc
@@ -75,15 +75,18 @@ ReliableQuicStream* QuicSession::CreateOutgoingDynamicStream(
net::SpdyPriority priority) {
ReliableQuicStream* stream = CreateDataStream(GetNextOutgoingStreamId());
if (stream) {
- ActivateStream(stream);
+ ActivateStream(stream); // QuicSession owns the stream
+ // Register the stream to the QuicWriteBlockedList. |priority| is clamped
+ // between 0 and 7, with 0 being the highest priority and 7 the lowest
+ // priority.
+ // write_blocked_streams()->RegisterStream(stream->id(), priority);
pthatcher1 2016/03/30 20:34:50 What is this commented-out line?
mikescarlett 2016/04/05 19:58:53 Removed. I was originally intending to allow setti
}
return stream;
}
ReliableQuicStream* QuicSession::CreateDataStream(net::QuicStreamId id) {
if (crypto_stream_ == nullptr || !crypto_stream_->encryption_established()) {
- // Encryption not active so no stream created
- return nullptr;
+ return nullptr; // Encryption not active so no stream created
}
return new ReliableQuicStream(id, this);
}
@@ -102,4 +105,9 @@ bool QuicSession::OnReadPacket(const char* data, size_t data_len) {
return true;
}
+void QuicSession::CloseStream(net::QuicStreamId stream_id) {
+ // write_blocked_streams()->UnregisterStream(stream_id);
+ net::QuicSession::CloseStream(stream_id);
+}
+
} // namespace cricket

Powered by Google App Engine
This is Rietveld 408576698