Modify PeerConnection for end-to-end QuicDataChannel usage

webrtc/p2p/quic/quicsession.cc

 /*
  *  Copyright 2016 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 57 matching lines @@
   if (stream) {
     SignalIncomingStream(stream);
   }
   return stream;
 }
 
 ReliableQuicStream* QuicSession::CreateOutgoingDynamicStream(
     net::SpdyPriority priority) {
   ReliableQuicStream* stream = CreateDataStream(GetNextOutgoingStreamId());
   if (stream) {
-    ActivateStream(stream);
+    ActivateStream(stream);  // QuicSession owns the stream
+    // Register the stream to the QuicWriteBlockedList. |priority| is clamped
+    // between 0 and 7, with 0 being the highest priority and 7 the lowest
+    // priority.
+    // write_blocked_streams()->RegisterStream(stream->id(), priority);

[pthatcher1, 2016/03/30 20:34:50]

What is this commented-out line?

[mikescarlett, 2016/04/05 19:58:53]

Removed. I was originally intending to allow setting write priority for QUIC
streams, but am leaving it out of this CL.

   }
   return stream;
 }
 
 ReliableQuicStream* QuicSession::CreateDataStream(net::QuicStreamId id) {
   if (crypto_stream_ == nullptr || !crypto_stream_->encryption_established()) {
-    // Encryption not active so no stream created
-    return nullptr;
+    return nullptr;  // Encryption not active so no stream created
   }
   return new ReliableQuicStream(id, this);
 }
 
 void QuicSession::OnConnectionClosed(net::QuicErrorCode error,
                                      net::ConnectionCloseSource source) {
   net::QuicSession::OnConnectionClosed(error, source);
   SignalConnectionClosed(error,
                          source == net::ConnectionCloseSource::FROM_PEER);
 }
 
 bool QuicSession::OnReadPacket(const char* data, size_t data_len) {
   net::QuicEncryptedPacket packet(data, data_len);
   connection()->ProcessUdpPacket(connection()->self_address(),
                                  connection()->peer_address(), packet);
   return true;
 }
 
+void QuicSession::CloseStream(net::QuicStreamId stream_id) {
+  // write_blocked_streams()->UnregisterStream(stream_id);
+  net::QuicSession::CloseStream(stream_id);
+}
+
 }  // namespace cricket