Modify PeerConnection for end-to-end QuicDataChannel usage

webrtc/base/bytebuffer_unittest.cc

 /*
  *  Copyright 2004 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 143 matching lines @@
 
     // Write and read uint64_t.
     uint32_t another32 = (8 << 24) + (7 << 16) + (6 << 8) + 5;
     uint64_t wu64 = (static_cast<uint64_t>(another32) << 32) + wu32;
     buffer.WriteUInt64(wu64);
     uint64_t ru64;
     EXPECT_TRUE(buffer.ReadUInt64(&ru64));
     EXPECT_EQ(wu64, ru64);
     EXPECT_EQ(0U, buffer.Length());
 
+    // Write and read varint.

[pthatcher1, 2016/03/30 20:34:50]

What does this mean?

[mikescarlett, 2016/04/05 19:58:52]

This doesn't belong here, removed

+
     // Write and read string.
     std::string write_string("hello");
     buffer.WriteString(write_string);
     std::string read_string;
     EXPECT_TRUE(buffer.ReadString(&read_string, write_string.size()));
     EXPECT_EQ(write_string, read_string);
     EXPECT_EQ(0U, buffer.Length());
 
     // Write and read bytes
     char write_bytes[] = "foo";
@@ skipping 28 matching lines @@
     EXPECT_TRUE(buffer.ReadUInt24(&ru24));
     EXPECT_EQ(wu24, ru24);
     EXPECT_TRUE(buffer.ReadUInt32(&ru32));
     EXPECT_EQ(wu32, ru32);
     EXPECT_TRUE(buffer.ReadUInt64(&ru64));
     EXPECT_EQ(wu64, ru64);
     EXPECT_EQ(0U, buffer.Length());
   }
 }
 
+TEST(ByteBufferTest, TestReadWriteVarint) {

[pthatcher1, 2016/03/30 20:34:50]

Uvarint

[mikescarlett, 2016/04/05 19:58:52]

Done.

+  ByteBuffer write_buffer(nullptr, 0, rtc::ByteBuffer::ByteOrder::ORDER_HOST);
+  size_t size = 0;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  write_buffer.WriteVarint(1u);
+  ++size;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  write_buffer.WriteVarint(2u);
+  ++size;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  write_buffer.WriteVarint(27u);
+  ++size;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  write_buffer.WriteVarint(149u);
+  size += 2;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  write_buffer.WriteVarint(68719476736u);
+  size += 6;
+  EXPECT_EQ(size, write_buffer.Length());
+
+  ByteBuffer read_buffer(write_buffer.Data(), write_buffer.Length(),
+                         rtc::ByteBuffer::ByteOrder::ORDER_HOST);

[pthatcher1, 2016/03/30 20:34:50]

Test with ORDER_NETWORK also.

[mikescarlett, 2016/04/05 19:58:52]

Done.

+  EXPECT_EQ(size, read_buffer.Length());
+  uint64_t val1, val2, val3, val4, val5;
+
+  ASSERT_TRUE(read_buffer.ReadVarint(&val1));
+  EXPECT_EQ(1u, val1);
+  --size;
+  EXPECT_EQ(size, read_buffer.Length());
+
+  ASSERT_TRUE(read_buffer.ReadVarint(&val2));
+  EXPECT_EQ(2u, val2);
+  --size;
+  EXPECT_EQ(size, read_buffer.Length());
+
+  ASSERT_TRUE(read_buffer.ReadVarint(&val3));
+  EXPECT_EQ(27u, val3);
+  --size;
+  EXPECT_EQ(size, read_buffer.Length());
+
+  ASSERT_TRUE(read_buffer.ReadVarint(&val4));
+  EXPECT_EQ(149u, val4);
+  size -= 2;
+  EXPECT_EQ(size, read_buffer.Length());
+
+  ASSERT_TRUE(read_buffer.ReadVarint(&val5));
+  EXPECT_EQ(68719476736u, val5);
+  size -= 6;
+  EXPECT_EQ(size, read_buffer.Length());
+}
+
 }  // namespace rtc