Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1844793007: Remove "#pragma comment(lib" in net. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "#pragma comment(lib" in net. BUG=597028 Committed: https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6 Cr-Commit-Position: refs/heads/master@{#384710}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -26 lines) Patch
M net/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M net/base/keygen_handler_win.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/base/network_interfaces_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/cert_database_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/x509_cert_types_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/dns/dns_config_service_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_ntlm_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/url_security_manager_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/net_common.gypi View 1 1 chunk +28 lines, -0 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/dhcp_proxy_script_fetcher_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_winhttp.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
4 years, 8 months ago (2016-04-01 17:35:59 UTC) #2
eroman
lgtm
4 years, 8 months ago (2016-04-01 19:05:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844793007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844793007/20001
4 years, 8 months ago (2016-04-01 21:13:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 22:36:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 22:38:55 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5332a63125aa1dead5af575d57a63c17013db1a6
Cr-Commit-Position: refs/heads/master@{#384710}

Powered by Google App Engine
This is Rietveld 408576698