Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3935)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java

Issue 1844793004: [MediaRouter, Android] Don't ignore device selection dialog failures in MediaRouter integration tes… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo remove comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java b/chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java
index 88db6440694f03118f31460fb0d7c5576bb5c363..3206b3e9ce30d1c742126dd476a894f12846f91e 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java
@@ -37,7 +37,7 @@ public class RouterTestUtils {
public View call() {
Dialog mediaRouteListDialog = getDialog(activity);
if (mediaRouteListDialog == null) {
- Log.w(TAG, "Cannot find choose device dialog");
+ Log.w(TAG, "Cannot find device selection dialog");
return null;
}
View mediaRouteList =
@@ -53,7 +53,7 @@ public class RouterTestUtils {
Log.w(TAG, "Cannot find wanted device");
return null;
}
-
+ Log.i(TAG, "Found wanted device");
return routesWanted.get(0);
}
}, maxTimeoutMs, intervalMs);
@@ -67,7 +67,13 @@ public class RouterTestUtils {
@Override
public boolean isSatisfied() {
try {
- return getDialog(activity) != null;
+ if (getDialog(activity) != null) {
+ Log.i(TAG, "Found device selection dialog");
+ return true;
+ } else {
+ Log.w(TAG, "Cannot find device selection dialog");
+ return false;
+ }
} catch (Exception e) {
return false;
}
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698