Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1844793004: [MediaRouter, Android] Don't ignore device selection dialog failures in MediaRouter integration tes… (Closed)

Created:
4 years, 8 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MediaRouter, Android] Don't ignore device selection dialog failures in MediaRouter integration tests Device selection dialog failures were ignored due to some issue of running the tests on some bots. This CL reenables these checks again. If the wanted device cannot be found in the device selection dialog, the tests will fail. BUG=587870 Committed: https://crrev.com/b54f5f9877a30cf082d36230c5d2f5de04f421f9 Cr-Commit-Position: refs/heads/master@{#384307}

Patch Set 1 #

Total comments: 1

Patch Set 2 : undo remove comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -76 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java View 1 9 chunks +21 lines, -73 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Zhiqiang Zhang (Slow)
4 years, 8 months ago (2016-03-31 13:38:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844793004/1
4 years, 8 months ago (2016-03-31 13:38:42 UTC) #4
whywhat
lgtm https://codereview.chromium.org/1844793004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java (left): https://codereview.chromium.org/1844793004/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java#oldcode39 chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java:39: * TODO(jbudorick): Remove this when media_router_integration_browsertest runs on ...
4 years, 8 months ago (2016-03-31 13:59:18 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 14:10:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844793004/20001
4 years, 8 months ago (2016-03-31 16:10:33 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 16:50:33 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 16:52:13 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b54f5f9877a30cf082d36230c5d2f5de04f421f9
Cr-Commit-Position: refs/heads/master@{#384307}

Powered by Google App Engine
This is Rietveld 408576698