components/navigation_metrics/navigation_metrics.h - Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/navigation_metrics/navigation_metrics.h

Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Describe |HaveAlreadySeen|'s side-effect. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tab_contents/navigation_metrics_recorder.cc ('K') | « chrome/browser/tab_contents/navigation_metrics_recorder.cc ('k') | components/navigation_metrics/navigation_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/navigation_metrics/navigation_metrics.h

diff --git a/components/navigation_metrics/navigation_metrics.h b/components/navigation_metrics/navigation_metrics.h

index aa6ef008c2a960bdf1a682c9771631439c582957..05176b7ed16f138ac3c63c763fe40f89c2862d62 100644

--- a/components/navigation_metrics/navigation_metrics.h

+++ b/components/navigation_metrics/navigation_metrics.h

@@ -9,7 +9,10 @@ class GURL;

namespace navigation_metrics {

-void RecordMainFrameNavigation(const GURL& url, bool is_in_page);

+void RecordMainFrameNavigation(const GURL& url,

+ bool is_in_page,

+ bool is_off_the_record,

+ bool have_already_seen_origin);

} // namespace navigation_metrics