chrome/browser/profiles/profile_io_data.cc - Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Describe |HaveAlreadySeen|'s side-effect. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_io_data.h ('K') | « chrome/browser/profiles/profile_io_data.h ('k') | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('j') | chrome/browser/tab_contents/navigation_metrics_recorder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_io_data.cc

diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc

index 39ec7628594b68bd18c44e8c8817c982a3eb6202..5de111e8967130b63339307345dcb8cfb23f7d85 100644

--- a/chrome/browser/profiles/profile_io_data.cc

+++ b/chrome/browser/profiles/profile_io_data.cc

@@ -868,6 +868,10 @@ bool ProfileIOData::IsOffTheRecord() const {

|| profile_type() == Profile::GUEST_PROFILE;

}

+bool ProfileIOData::HaveAlreadySeenOrigin(const url::Origin& origin) {

+ return origins_seen_.insert(origin).second == false;

void ProfileIOData::InitializeMetricsEnabledStateOnUIThread() {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

#if BUILDFLAG(ANDROID_JAVA_UI)