Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: chrome/browser/profiles/profile_io_data.cc

Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_io_data.cc
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 3d439fb2d92992a0de46bce4b720a20f66bb01a6..606e84c6da5097ae6dfac23e7ca56cbac7092fcb 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -864,6 +864,10 @@ bool ProfileIOData::IsOffTheRecord() const {
|| profile_type() == Profile::GUEST_PROFILE;
}
+bool ProfileIOData::HaveAlreadySeenOrigin(const url::Origin& origin) {
+ return origins_seen_.insert(origin).second == false;
felt 2016/04/07 02:28:04 seems unexpected to me (based on method name & des
palmer 2016/04/07 23:45:43 What would you rather do? I want to let the calle
felt 2016/04/07 23:51:15 I agree it makes sense to keep it a single method.
+}
+
void ProfileIOData::InitializeMetricsEnabledStateOnUIThread() {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
#if BUILDFLAG(ANDROID_JAVA_UI)

Powered by Google App Engine
This is Rietveld 408576698