Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: chrome/browser/tab_contents/origins_seen_service.h

Issue 1844753002: Histogram the scheme of an origin on the 1st navigation to it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove commented-out line. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_ORIGINS_SEEN_SERVICE_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_ORIGINS_SEEN_SERVICE_H_
7
8 #include "base/containers/mru_cache.h"
9 #include "components/keyed_service/core/keyed_service.h"
10 #include "url/origin.h"
11
12 class OriginsSeenService : public KeyedService {
13 public:
14 OriginsSeenService();
15 ~OriginsSeenService() override;
16
17 // Used when deciding whether or not to record
18 // Navigation.SchemePerUniqueOrigin[OTR]. Inserts a copy of |origin| into the
19 // set |origins_seen_|, and returns whether or not |origin| was already in the
20 // set.
21 bool HaveAlreadySeenOrigin(const url::Origin& origin);
battre 2016/04/18 15:20:51 Nit (up to you): The function name suggests that t
palmer 2016/04/18 20:12:44 Done.
22
23 private:
24 // Used by |HaveAlreadySeenOrigin|.
25 base::MRUCache<url::Origin, bool> origins_seen_;
battre 2016/04/18 15:20:51 Can you add a comment that this is intentionally i
palmer 2016/04/18 20:12:43 Done.
26 };
27
28 #endif // CHROME_BROWSER_TAB_CONTENTS_ORIGINS_SEEN_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698