Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 1844733003: Restart the engine within the docker container when appropriate. (Closed)

Created:
4 years, 8 months ago by marcinjb
Modified:
4 years, 8 months ago
Reviewers:
Sriram, Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restart the engine within the docker container when appropriate. It's possible for the engine to exit successfully right now (when a connection is lost). The current state of start_engine.sh will cause the Docker container to exit in this case, which isn't desired behavior. This patch changes the behavior so that the engine will continuously be restarted within the Docker container so long as it exits cleanly. If the engine exits with a nonzero code (or if stunnel bombs out), the Docker container will be torn down. BUG=598933 Committed: https://crrev.com/7e8f69e15bd7e054e4c3cbb5e6b70870adb1951e Cr-Commit-Position: refs/heads/master@{#384139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M blimp/engine/start_engine.sh View 1 chunk +23 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
marcinjb
FYI: I tested this locally. I ran a docker container with stunnel and the like, ...
4 years, 8 months ago (2016-03-30 22:58:11 UTC) #3
Kevin M
lgtm
4 years, 8 months ago (2016-03-30 22:59:26 UTC) #4
Sriram
On 2016/03/30 22:59:26, Kevin M wrote: > lgtm LGTM
4 years, 8 months ago (2016-03-30 23:04:08 UTC) #5
Sriram
On 2016/03/30 22:59:26, Kevin M wrote: > lgtm LGTM
4 years, 8 months ago (2016-03-30 23:04:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844733003/1
4 years, 8 months ago (2016-03-30 23:07:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 23:13:40 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 23:15:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8f69e15bd7e054e4c3cbb5e6b70870adb1951e
Cr-Commit-Position: refs/heads/master@{#384139}

Powered by Google App Engine
This is Rietveld 408576698