Sync Blob.close() behavior wrt updated spec.

Source/core/fileapi/Blob.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "core/fileapi/Blob.h"
 
+#include "bindings/v8/ExceptionState.h"
 #include "core/dom/DOMURL.h"
+#include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
 #include "platform/blob/BlobRegistry.h"
 #include "platform/blob/BlobURL.h"
 
 namespace WebCore {
 
 namespace {
 
 class BlobURLRegistry FINAL : public URLRegistry {
 public:
@@ skipping 51 matching lines @@
         end = 0;
     if (start >= size) {
         start = 0;
         end = 0;
     } else if (end < start)
         end = start;
     else if (end > size)
         end = size;
 }
 
-PassRefPtr<Blob> Blob::slice(long long start, long long end, const String& contentType) const
+PassRefPtr<Blob> Blob::slice(long long start, long long end, const String& contentType, ExceptionState& exceptionState) const
 {
+    if (hasBeenClosed()) {
+        exceptionState.throwDOMException(InvalidStateError, "Blob has been closed.");
+        return nullptr;
+    }
+
     long long size = this->size();
     clampSliceOffsets(size, start, end);
 
     long long length = end - start;
     OwnPtr<BlobData> blobData = BlobData::create();
     blobData->setContentType(contentType);
     blobData->appendBlob(m_blobDataHandle, start, length);
     return Blob::create(BlobDataHandle::create(blobData.release(), length));
 }
 
-void Blob::close(ExecutionContext* executionContext)
+void Blob::close(ExecutionContext* executionContext, ExceptionState& exceptionState)
 {
-    if (!hasBeenClosed()) {
-        // Dereferencing a Blob that has been closed should result in
-        // a network error. Revoke URLs registered against it through
-        // its UUID.
-        DOMURL::revokeObjectUUID(executionContext, uuid());
+    if (hasBeenClosed()) {
+        exceptionState.throwDOMException(InvalidStateError, "Blob has been closed.");
+        return;
+    }
 
-        // A closed Blob should have size zero, which most consumers
-        // will treat as an empty Blob. The exception being the FileReader
-        // read operations which will throw.
-        // FIXME: spec not yet set in stone in this regard, track updates to it (http://crbug.com/344820.)
-        OwnPtr<BlobData> blobData = BlobData::create();
-        blobData->setContentType(type());
-        m_blobDataHandle = BlobDataHandle::create(blobData.release(), 0);
-        m_hasBeenClosed = true;
-    }
+    // Dereferencing a Blob that has been closed should result in
+    // a network error. Revoke URLs registered against it through
+    // its UUID.
+    DOMURL::revokeObjectUUID(executionContext, uuid());
+
+    // A Blob enters a 'readability state' of closed, where it will report its
+    // size as zero. Blob and FileReader operations now throws on
+    // being passed a Blob in that state. Downstream uses of closed Blobs
+    // (e.g., XHR.send()) consider them as empty.
+    OwnPtr<BlobData> blobData = BlobData::create();
+    blobData->setContentType(type());
+    m_blobDataHandle = BlobDataHandle::create(blobData.release(), 0);
+    m_hasBeenClosed = true;
 }
 
 void Blob::appendTo(BlobData& blobData) const
 {
     blobData.appendBlob(m_blobDataHandle, 0, m_blobDataHandle->size());
 }
 
 URLRegistry& Blob::registry() const
 {
     return BlobURLRegistry::registry();
 }
 
 } // namespace WebCore