Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1844723003: Move metrics list storage to LayoutSVGInlineText (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move metrics list storage to LayoutSVGInlineText It was previously stored in SVGTextLayoutAttributes (which is stored in LayoutSVGInlineText). The connection between these two is very loose, so letting the metrics be a part of the attributes structure doesn't feel entirely logical. There's still a back-pointer in the attributes structure, which means it's still reachable in the same way (albeit with one additional indirection.) Rename the various accessors to metricsList(). BUG=594058 Committed: https://crrev.com/91d29a30053008ec263fdeeda7e51d0c7cadc1a8 Cr-Commit-Position: refs/heads/master@{#384450}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
fs
4 years, 8 months ago (2016-03-30 18:23:15 UTC) #2
pdr.
On 2016/03/30 at 18:23:15, fs wrote: > LGTM! I was unsure at first, but https://crbug.com/594058#c9 ...
4 years, 8 months ago (2016-03-31 23:10:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844723003/1
4 years, 8 months ago (2016-03-31 23:11:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 00:44:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 00:45:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91d29a30053008ec263fdeeda7e51d0c7cadc1a8
Cr-Commit-Position: refs/heads/master@{#384450}

Powered by Google App Engine
This is Rietveld 408576698