Test decoding and output failures to JSON in get_images_from_skps

Test decoding and output failures to JSON in get_images_from_skps.

Testing for decoding was copy pasted from msarett's CL https://codereview.chromium.org/1828323002/

BUG=skia:4981
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844713003

Committed: https://skia.googlesource.com/skia/+/8d965a612e3963e039fa19e74c09d942398c611a

[rmistry, 2016-03-30 18:25:28]

Description was changed from

==========
Checkpoint

BUG=skia:
==========

to

==========
Checkpoint

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[rmistry, 2016-04-25 15:05:40]

Description was changed from

==========
Checkpoint

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test decoding and output failures to JSON in get_images_from_skps.

Testing for decoding was copy pasted from msarett's CL
https://codereview.chromium.org/1828323002/

BUG=skia:4981
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[rmistry, 2016-04-25 15:12:39]

rmistry@google.com changed reviewers:
+ msarett@google.com

[rmistry, 2016-04-25 15:28:28]

The CQ bit was checked by rmistry@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-25 15:28:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844713003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844713003/160001

[msarett, 2016-04-25 15:29:53]

lgtm

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
File tools/get_images_from_skps.cpp (right):

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:28: "Dump SKP and count of unknown images to the
specified JSON file. Wll not be "
nit: *Will

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:59: SkDebugf("Codec could not be created for
%s\n", skpName.c_str());
I believe this is unreachable...  Looks like we create an empty generator if we
fail to create a codec.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...

Still I think your change is correct.  Maybe add a FIXME though?

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:74: SkDebugf("Unrecognized encoded format for
%s\n", skpName.c_str());
I think this is also unreachable - just because we can't create a codec if we
don't know the image type.

I realize this issue was not caused by your change, but maybe SkASSERT(false)
here?

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:83: if (SkCodec::kSuccess !=
codec->getPixels(info, bitmap.getPixels(),  bitmap.rowBytes()))
Our dm tests treat kSuccess and kIncompleteInput as "successes" because we test
on incomplete images.

I think this is good as is for now - I'm not sure how many incomplete images are
in our skps.  But if incomplete images are causing failures, we may need to
modify this.

[commit-bot: I haz the power, 2016-04-25 16:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 16:05:11]

Dry run: This issue passed the CQ dry run.

[rmistry, 2016-04-25 17:11:45]

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
File tools/get_images_from_skps.cpp (right):

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:28: "Dump SKP and count of unknown images to the
specified JSON file. Wll not be "
On 2016/04/25 15:29:53, msarett wrote:
> nit: *Will

Oops. Done.

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:59: SkDebugf("Codec could not be created for
%s\n", skpName.c_str());
On 2016/04/25 15:29:53, msarett wrote:
> I believe this is unreachable...  Looks like we create an empty generator if
we
> fail to create a codec.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/skia/s...
> 
> Still I think your change is correct.  Maybe add a FIXME though?
> 

Done.

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:74: SkDebugf("Unrecognized encoded format for
%s\n", skpName.c_str());
On 2016/04/25 15:29:53, msarett wrote:
> I think this is also unreachable - just because we can't create a codec if we
> don't know the image type.
> 
> I realize this issue was not caused by your change, but maybe SkASSERT(false)
> here?

Done.

https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_...
tools/get_images_from_skps.cpp:83: if (SkCodec::kSuccess !=
codec->getPixels(info, bitmap.getPixels(),  bitmap.rowBytes()))
On 2016/04/25 15:29:53, msarett wrote:
> Our dm tests treat kSuccess and kIncompleteInput as "successes" because we
test
> on incomplete images.
> 
> I think this is good as is for now - I'm not sure how many incomplete images
are
> in our skps.  But if incomplete images are causing failures, we may need to
> modify this.

k, lets leave this in for now. I am guessing we will end up running into this
once we test on 10,000 SKPs.

[msarett, 2016-04-25 17:13:14]

LGTM!

[rmistry, 2016-04-25 17:21:44]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2016-04-25 17:21:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844713003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844713003/180001

[commit-bot: I haz the power, 2016-04-25 17:35:06]

Description was changed from

==========
Test decoding and output failures to JSON in get_images_from_skps.

Testing for decoding was copy pasted from msarett's CL
https://codereview.chromium.org/1828323002/

BUG=skia:4981
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Test decoding and output failures to JSON in get_images_from_skps.

Testing for decoding was copy pasted from msarett's CL
https://codereview.chromium.org/1828323002/

BUG=skia:4981
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8d965a612e3963e039fa19e74c09d942398c611a
==========

[commit-bot: I haz the power, 2016-04-25 17:35:07]

Committed patchset #10 (id:180001) as
https://skia.googlesource.com/skia/+/8d965a612e3963e039fa19e74c09d942398c611a