Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 18447003: MIPS: Adjust default Heap sizes. (Closed)

Created:
7 years, 5 months ago by palfia
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Adjust default Heap sizes. This change decreases the default Heap sizes on MIPS (sets the same sizes as on Android). Most MIPS hw has smaller RAM size than 700MB, which can lead to test failures, if a test does not set the Heap sizes explicitly (like cctest/test-mark-compact/MarkCompactCollector). BUG= Committed: https://code.google.com/p/v8/source/detail?r=15583

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
palfia
PTAL.
7 years, 5 months ago (2013-07-10 01:47:05 UTC) #1
Yang
On 2013/07/10 01:47:05, palfia wrote: > PTAL. LGTM.
7 years, 5 months ago (2013-07-10 08:09:14 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/18447003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/18447003/diff/1/src/heap.cc#newcode77 src/heap.cc:77: #if defined(ANDROID) || defined(V8_TARGET_ARCH_MIPS) nit: ...
7 years, 5 months ago (2013-07-10 08:10:25 UTC) #3
palfia
Thanks, fixed! https://codereview.chromium.org/18447003/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/18447003/diff/1/src/heap.cc#newcode77 src/heap.cc:77: #if defined(ANDROID) || defined(V8_TARGET_ARCH_MIPS) On 2013/07/10 08:10:25, ...
7 years, 5 months ago (2013-07-10 09:59:55 UTC) #4
palfia
7 years, 5 months ago (2013-07-10 10:01:36 UTC) #5
Message was sent while issue was closed.
Committed manually as r15583 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698