Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1844693003: Remove unnecessary inclusion of base/metrics/histogram.h (Closed)

Created:
4 years, 8 months ago by Ben Chan
Modified:
4 years, 8 months ago
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary inclusion of base/metrics/histogram.h This CL removes the unnecessary inclusion of base/metrics/histogram.h (introduced by crrev.com/308221) in base/message_loop/incoming_task_queue.cc. The latter doesn't actually use any of the code provided by histogram.h BUG=None Committed: https://crrev.com/1f9b1edc333b29b967c495e703dfeeff158faada Cr-Commit-Position: refs/heads/master@{#383883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/message_loop/incoming_task_queue.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844693003/1
4 years, 8 months ago (2016-03-29 21:29:06 UTC) #3
Ben Chan
4 years, 8 months ago (2016-03-29 23:06:33 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 23:33:09 UTC) #7
Ben Chan
4 years, 8 months ago (2016-03-30 00:21:27 UTC) #9
Lei Zhang
lgtm
4 years, 8 months ago (2016-03-30 00:26:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844693003/1
4 years, 8 months ago (2016-03-30 00:57:47 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 01:03:33 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 01:04:34 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f9b1edc333b29b967c495e703dfeeff158faada
Cr-Commit-Position: refs/heads/master@{#383883}

Powered by Google App Engine
This is Rietveld 408576698