Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1844623002: [DevTools] Fixed context menu breakage when edit dom in console (Closed)

Created:
4 years, 8 months ago by allada
Modified:
4 years, 8 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fixed context menu breakage when edit dom in console If you edit a DOM item in console it should now properly change view ports and go into editing mode instead of breaking elements panel and doing nothing. BUG=598166 R=lushnikov Committed: https://crrev.com/2b6b373f5ec762bf465c9a00a4d540b295b5c0a2 Cr-Commit-Position: refs/heads/master@{#383848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeElement.js View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
allada
PTL
4 years, 8 months ago (2016-03-29 18:53:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844623002/1
4 years, 8 months ago (2016-03-29 18:53:17 UTC) #3
lushnikov
lgtm, thanks
4 years, 8 months ago (2016-03-29 18:55:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 21:42:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844623002/1
4 years, 8 months ago (2016-03-29 22:16:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 22:23:51 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 22:25:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b6b373f5ec762bf465c9a00a4d540b295b5c0a2
Cr-Commit-Position: refs/heads/master@{#383848}

Powered by Google App Engine
This is Rietveld 408576698