Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1844553002: [wasm] New attempt to implement the Int64Lowering of phis. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] New attempt to implement the Int64Lowering of phis. The new implementation deals with cycles in the TF graph in two steps: 1) The lowering of phis is delayed to avoid cyclic dependencies. 2) The replacement nodes of phis are created already when the phi is pushed onto the stack so that other nodes can use these replacements for their lowering. R=titzer@chromium.org Committed: https://crrev.com/682df6dd331a434f6064867de6ef0043c9dbcda4 Cr-Commit-Position: refs/heads/master@{#35126}

Patch Set 1 #

Patch Set 2 : Fixed out-of-bounds memory access. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -9 lines) Patch
M src/compiler/int64-lowering.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/int64-lowering.cc View 1 4 chunks +58 lines, -6 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/int64-lowering-unittest.cc View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 8 months ago (2016-03-29 14:05:46 UTC) #1
titzer
lgtm this is so much cleaner! love it!
4 years, 8 months ago (2016-03-29 16:09:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844553002/20001
4 years, 8 months ago (2016-03-30 08:11:49 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 08:13:56 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 08:14:42 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/682df6dd331a434f6064867de6ef0043c9dbcda4
Cr-Commit-Position: refs/heads/master@{#35126}

Powered by Google App Engine
This is Rietveld 408576698