Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1844543002: [debugger] remove GeneratorMirror.prototype.context(). (Closed)

Created:
4 years, 8 months ago by Yang
Modified:
4 years, 8 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] remove GeneratorMirror.prototype.context(). I can't express my disbelief when I saw it getting a raw context object from the runtime. Luckily this is not used anywhere. R=neis@chromium.org Committed: https://crrev.com/6ffbae7f8fce8d820e12e8d25dfa761be4d4cb05 Cr-Commit-Position: refs/heads/master@{#35102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M src/debug/mirrors.js View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 8 months ago (2016-03-29 12:04:53 UTC) #1
neis
On 2016/03/29 12:04:53, Yang wrote: lgtm
4 years, 8 months ago (2016-03-29 12:09:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844543002/1
4 years, 8 months ago (2016-03-29 12:19:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 12:47:11 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 12:48:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ffbae7f8fce8d820e12e8d25dfa761be4d4cb05
Cr-Commit-Position: refs/heads/master@{#35102}

Powered by Google App Engine
This is Rietveld 408576698