ui/gfx/android/java_bitmap.h - Issue 184453002: Android::Pass Bitmap.Config instead of bool to CreateJavaBitmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/android/java_bitmap.h

Issue 184453002: Android::Pass Bitmap.Config instead of bool to CreateJavaBitmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass Bitmap.Config instead of bool to CreateJavaBitmap Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java ('K') | « ui/android/java/src/org/chromium/ui/gfx/BitmapHelper.java ('k') | ui/gfx/android/java_bitmap.cc » ('j') | ui/gfx/android/java_bitmap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/gfx/android/java_bitmap.h

diff --git a/ui/gfx/android/java_bitmap.h b/ui/gfx/android/java_bitmap.h

index cb1077d73e2ca49f6c8af26c8a107bda67398d6c..1ec31136ef7d397a5e9d2cadf55c1fab9fe35d12 100644

--- a/ui/gfx/android/java_bitmap.h

+++ b/ui/gfx/android/java_bitmap.h

@@ -62,6 +62,10 @@ GFX_EXPORT SkBitmap CreateSkBitmapFromResource(const char* name,

// Returns a Skia config value for the requested input java Bitmap.Config.

GFX_EXPORT SkBitmap::Config ConvertToSkiaConfig(jobject bitmap_config);

+// Returns the java Bitmap.Config for the requested skia config value.

+GFX_EXPORT base::android::ScopedJavaLocalRef<jobject> ConvertToJavaBitmapConfig(

bulach 2014/02/28 13:19:25 I think we can get away without this method.

sivag 2014/03/04 12:36:04 Moved it to a file level static method

sivag 2014/03/04 12:36:04 Done.

+ SkBitmap::Config bitmap_config);

} // namespace gfx

#endif // UI_GFX_ANDROID_JAVA_BITMAP_H_