Android::Pass Bitmap.Config instead of bool to CreateJavaBitmap

ui/gfx/android/java_bitmap.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/android/java_bitmap.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/jni_string.h"
 #include "base/logging.h"
@@ skipping 23 matching lines @@
 JavaBitmap::~JavaBitmap() {
   int err = AndroidBitmap_unlockPixels(AttachCurrentThread(), bitmap_);
   DCHECK(!err);
 }
 
 // static
 bool JavaBitmap::RegisterJavaBitmap(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
-static ScopedJavaLocalRef<jobject> CreateJavaBitmap(int width, int height,
-                                                    bool is565_config) {
-  return Java_BitmapHelper_createBitmap(AttachCurrentThread(),
-      width, height, is565_config);
+static ScopedJavaLocalRef<jobject> CreateJavaBitmap(int width,
+                                                    int height,
+                                                    int bitmap_config) {
+
+  return Java_BitmapHelper_createBitmap(
+      AttachCurrentThread(), width, height, bitmap_config);
+}
+
+static int SkBitmapConfigToBitmapFormat(SkBitmap::Config bitmap_config) {
+  int matching_enum_config = BITMAP_FORMAT_NO_CONFIG;

[bulach, 2014/03/04 13:05:13]

no need to initialize..

[sivag, 2014/03/04 13:57:55]

Done.

+  switch (bitmap_config) {
+    case SkBitmap::kA8_Config:
+      matching_enum_config = BITMAP_FORMAT_ALPHA_8;

[bulach, 2014/03/04 13:05:13]

would it be possible to just "return" on these case clauses?

[sivag, 2014/03/04 13:57:55]

Done.

+      break;
+    case SkBitmap::kARGB_4444_Config:
+      matching_enum_config = BITMAP_FORMAT_ARGB_4444;
+      break;
+    case SkBitmap::kARGB_8888_Config:
+      matching_enum_config = BITMAP_FORMAT_ARGB_8888;
+      break;
+    case SkBitmap::kRGB_565_Config:
+      matching_enum_config = BITMAP_FORMAT_RGB_565;
+      break;
+    case SkBitmap::kNo_Config:
+    default:
+      matching_enum_config = BITMAP_FORMAT_NO_CONFIG;
+      break;
+  }
+  DCHECK(matching_enum_config == BITMAP_FORMAT_NO_CONFIG);

[bulach, 2014/03/04 13:05:13]

shouldn't this be != ?

[sivag, 2014/03/04 13:57:55]

Done.

+  return matching_enum_config;
 }
 
 ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(const SkBitmap* skbitmap) {
   DCHECK(skbitmap);
   SkBitmap::Config config = skbitmap->getConfig();
   DCHECK((config == SkBitmap::kRGB_565_Config) ||
          (config == SkBitmap::kARGB_8888_Config));
   // If the Config is not RGB565 it is default i.e ARGB8888

[bulach, 2014/03/04 13:05:13]

this comment is obsolete now..

[sivag, 2014/03/04 13:57:55]

Done.

-  ScopedJavaLocalRef<jobject> jbitmap =
-      CreateJavaBitmap(skbitmap->width(), skbitmap->height(),
-                       (config == SkBitmap::kRGB_565_Config));
+  int java_bitmap_config = SkBitmapConfigToBitmapFormat(config);
+  ScopedJavaLocalRef<jobject> jbitmap = CreateJavaBitmap(
+      skbitmap->width(), skbitmap->height(), java_bitmap_config);
   SkAutoLockPixels src_lock(*skbitmap);
   JavaBitmap dst_lock(jbitmap.obj());
   void* src_pixels = skbitmap->getPixels();
   void* dst_pixels = dst_lock.pixels();
   memcpy(dst_pixels, src_pixels, skbitmap->getSize());
 
   return jbitmap;
 }
 
 SkBitmap CreateSkBitmapFromJavaBitmap(JavaBitmap& jbitmap) {
@@ skipping 26 matching lines @@
   if (jobj.is_null())
     return SkBitmap();
 
   JavaBitmap jbitmap(jobj.obj());
   SkBitmap bitmap = CreateSkBitmapFromJavaBitmap(jbitmap);
   return skia::ImageOperations::Resize(
       bitmap, skia::ImageOperations::RESIZE_BOX, size.width(), size.height());
 }
 
 SkBitmap::Config ConvertToSkiaConfig(jobject bitmap_config) {
-  int jbitmap_config =
-      Java_BitmapHelper_bitmapConfig(AttachCurrentThread(), bitmap_config);
+  int jbitmap_config = Java_BitmapHelper_getConfigEnumValue(
+      AttachCurrentThread(), bitmap_config);
   switch (jbitmap_config) {
     case BITMAP_FORMAT_ALPHA_8:
       return SkBitmap::kA8_Config;
     case BITMAP_FORMAT_ARGB_4444:
       return SkBitmap::kARGB_4444_Config;
     case BITMAP_FORMAT_ARGB_8888:
       return SkBitmap::kARGB_8888_Config;
     case BITMAP_FORMAT_RGB_565:
       return SkBitmap::kRGB_565_Config;
     case BITMAP_FORMAT_NO_CONFIG:
     default:
       return SkBitmap::kNo_Config;
   }
 }
 
 }  //  namespace gfx