Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18445003: Some rebaselines in the spirit of https://groups.google.com/a/chromium.org/forum/#!search/on$20layo… (Closed)

Created:
7 years, 5 months ago by ojan
Modified:
7 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

Some rebaselines in the spirit of https://groups.google.com/a/chromium.org/forum/#!search/on$20layout$20tests/blink-dev/hsPset9L06E/Evii--bVNwQJ As best I can tell, these are all non-flaky results. Also, cleaned up a few comments here and there. TBR=adamk@chromium.org BUG=237679 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -747 lines) Patch
M LayoutTests/TestExpectations View 6 chunks +0 lines, -32 lines 0 comments Download
M LayoutTests/compositing/tiled-layers-hidpi-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/dom/DeviceMotion/create-event-expected.txt View 1 chunk +2 lines, -16 lines 0 comments Download
M LayoutTests/fast/dom/DeviceMotion/optional-event-properties-expected.txt View 1 chunk +90 lines, -78 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt View 1 chunk +0 lines, -128 lines 0 comments Download
D LayoutTests/platform/chromium-mac-lion/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/platform/chromium-mac-lion/fast/forms/basic-buttons-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac-snowleopard/fast/forms/basic-buttons-expected.png View Binary file 0 comments Download
D LayoutTests/platform/chromium-mac/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/chromium-mac/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/chromium-mac/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt View 1 chunk +127 lines, -0 lines 0 comments Download
D LayoutTests/platform/chromium-mac/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium-mac/fast/forms/basic-buttons-expected.png View Binary file 0 comments Download
M LayoutTests/platform/chromium-mac/fast/forms/basic-buttons-expected.txt View 7 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/chromium-mac/virtual/softwarecompositing/tiling/huge-layer-img-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + LayoutTests/platform/linux-x86/compositing/tiled-layers-hidpi-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/platform/linux/compositing/tiled-layers-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/linux/editing/style/unbold-in-bold-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/basic-buttons-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/forms/basic-buttons-expected.txt View 7 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/win/editing/style/unbold-in-bold-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-expected.txt View 1 chunk +0 lines, -85 lines 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt View 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/platform/win/fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/basic-buttons-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/forms/basic-buttons-expected.txt View 7 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/win/virtual/softwarecompositing/tiling/huge-layer-img-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A + LayoutTests/virtual/softwarecompositing/tiled-layers-hidpi-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ojan
7 years, 5 months ago (2013-07-02 01:08:21 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r153390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698