Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1844473002: S390: Fix CEBR sim to treat operands as floats (Closed)

Created:
4 years, 8 months ago by JoranSiu
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix CEBR sim to treat operands as floats Fix bug in simulator which incorrectly interpreted the operands for CEBR (Float32 compare) as 64-bit doubles. Add missing disassembler case for CEBR as well. R=jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Committed: https://crrev.com/27df7757e52310ab3311175d4a7fe8da73c4e3e3 Cr-Commit-Position: refs/heads/master@{#35106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844473002/1
4 years, 8 months ago (2016-03-29 03:40:27 UTC) #2
JoranSiu
4 years, 8 months ago (2016-03-29 03:41:06 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-29 04:01:06 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-03-29 12:44:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844473002/1
4 years, 8 months ago (2016-03-29 13:06:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 13:14:38 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 13:15:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27df7757e52310ab3311175d4a7fe8da73c4e3e3
Cr-Commit-Position: refs/heads/master@{#35106}

Powered by Google App Engine
This is Rietveld 408576698