Fixing a Dr. memory failure in the remoting unit tests.

Fixing a Dr. memory failure in the remoting unit tests.

The test I checked in yesterday had a race condition in it which was detected
by the Dr. Memory bot (they run more slowly than the normal bots).  On a
normal bot, my runloop quits when the first (of ~11) message is written but
the other messages are processed and added to the vector by the time it is
checked.  On the Dr. Memory bot, this condition was exposed and the size check
failed.  The fix is to ensure that we are processing each message as it is
written/received and validating the size afterwards.

BUG=599494
Committed: https://crrev.com/d0c1837abcd55db74ad07220bcc13e4c7dfb7e82
Cr-Commit-Position: refs/heads/master@{#384354}

[joedow, 2016-03-31 16:08:57]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-03-31 16:08:58]

This CL fixes a race condition in one of the unit tests I checked in yesterday. 
PTAL!

Thanks,
Joe

[joedow, 2016-03-31 17:00:37]

Made a fix for a non-windows test failure.

[Sergey Ulanov, 2016-03-31 18:42:33]

lgtm

[joedow, 2016-03-31 18:59:31]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-03-31 19:00:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844423002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844423002/40001

[commit-bot: I haz the power, 2016-03-31 19:10:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-31 19:12:20]

Description was changed from

==========
Fixing a Dr. memory failure in the remoting unit tests.

The test I checked in yesterday had a race condition in it which was detected
by the Dr. Memory bot (they run more slowly than the normal bots).  On a
normal bot, my runloop quits when the first (of ~11) message is written but
the other messages are processed and added to the vector by the time it is
checked.  On the Dr. Memory bot, this condition was exposed and the size check
failed.  The fix is to ensure that we are processing each message as it is
written/received and validating the size afterwards.

BUG=599494
==========

to

==========
Fixing a Dr. memory failure in the remoting unit tests.

The test I checked in yesterday had a race condition in it which was detected
by the Dr. Memory bot (they run more slowly than the normal bots).  On a
normal bot, my runloop quits when the first (of ~11) message is written but
the other messages are processed and added to the vector by the time it is
checked.  On the Dr. Memory bot, this condition was exposed and the size check
failed.  The fix is to ensure that we are processing each message as it is
written/received and validating the size afterwards.

BUG=599494

Committed: https://crrev.com/d0c1837abcd55db74ad07220bcc13e4c7dfb7e82
Cr-Commit-Position: refs/heads/master@{#384354}
==========

[commit-bot: I haz the power, 2016-03-31 19:12:21]

Patchset 3 (id:??) landed as
https://crrev.com/d0c1837abcd55db74ad07220bcc13e4c7dfb7e82
Cr-Commit-Position: refs/heads/master@{#384354}

[benwells, 2016-04-01 04:50:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1849023004/ by benwells@chromium.org.

The reason for reverting is: However, this was the data posted to the server:

revert_reason: This change has caused failures on TSAN, and also caused the
DrMemory bot to timeout.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Test...

and 

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...
revert_cq: 1
revert_reason_textarea: This change has caused failures on TSAN, and also caused
the DrMemory bot to timeout.

See
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Test...

and 

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%2...
xsrf_token: 3f3abe97db5300c6623390914f94b515
.