Support ReferrerPolicy in Fetch API

Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
Committed: https://crrev.com/a8e98a61a6144db6a2b45baaff9eeb8930f0296f
Cr-Commit-Position: refs/heads/master@{#389753}

[yhirano, 2016-04-01 10:48:51]

Description was changed from

==========
Support ReferrerPolicy on Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
==========

to

==========
Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
==========

[yhirano, 2016-04-01 10:59:53]

Patchset #2 (id:20001) has been deleted

[yhirano, 2016-04-01 10:59:58]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-04-04 02:30:18]

Patchset #1 (id:40001) has been deleted

[yhirano, 2016-04-04 03:51:03]

Patchset #1 (id:60001) has been deleted

[yhirano, 2016-04-06 01:59:01]

Patchset #2 (id:100001) has been deleted

[yhirano, 2016-04-06 01:59:05]

Patchset #1 (id:80001) has been deleted

[yhirano, 2016-04-06 01:59:16]

Patchset #1 (id:120001) has been deleted

[yhirano, 2016-04-15 01:48:05]

Patchset #1 (id:130001) has been deleted

[yhirano, 2016-04-15 04:02:17]

Patchset #1 (id:150001) has been deleted

[yhirano, 2016-04-15 04:17:07]

Patchset #1 (id:170001) has been deleted

[yhirano, 2016-04-15 04:17:22]

yhirano@chromium.org changed reviewers:
+ estark@chromium.org, jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-15 12:04:18]

jochen@chromium.org changed reviewers:
+ mkwst@chromium.org

[jochen (gone - plz use gerrit), 2016-04-15 12:04:19]

+mkwst since it's his experiment

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:553: return
"no-referrer-when-downgrade";
hum, what about exposing a string for this anyways, just if the command line
flag is on?

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.idl (right):

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.idl:23: "origin-only",
should be "origin"

[yhirano, 2016-04-18 08:43:28]

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:553: return
"no-referrer-when-downgrade";
On 2016/04/15 12:04:19, jochen wrote:
> hum, what about exposing a string for this anyways, just if the command line
> flag is on?

Done.

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.idl (right):

https://codereview.chromium.org/1844413006/diff/190001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.idl:23: "origin-only",
On 2016/04/15 12:04:19, jochen wrote:
> should be "origin"

It's from https://fetch.spec.whatwg.org/#concept-referrer-policy.

[jochen (gone - plz use gerrit), 2016-04-18 08:46:02]

that looks like a bug in the fetch spec then. The referrer policy only defines
"origin"

[estark, 2016-04-18 09:21:27]

https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.idl (right):

https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.idl:25: "unsafe-url"
Does this need to include the newly added
"no-referrer-when-downgrade-origin-when-cross-origin" value? Or does it only
need to include official spec'ed non-experimental values?

[yhirano, 2016-04-18 09:31:03]

On 2016/04/18 08:46:02, jochen wrote:
> that looks like a bug in the fetch spec then. The referrer policy only defines
> "origin"

I don't have a strong opinion. Filed https://github.com/whatwg/fetch/issues/287.

[yhirano, 2016-04-19 14:24:10]

https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.idl (right):

https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.idl:25: "unsafe-url"
On 2016/04/18 09:21:27, estark wrote:
> Does this need to include the newly added
> "no-referrer-when-downgrade-origin-when-cross-origin" value? Or does it only
> need to include official spec'ed non-experimental values?

I'd like to not include no-referrer-when-downgrade-origin-when-cross-origin.

[yhirano, 2016-04-20 06:30:14]

s/origin-only/origin/g done. PTAL.

[jochen (gone - plz use gerrit), 2016-04-20 14:20:48]

On 2016/04/19 at 14:24:10, yhirano wrote:
>
https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/fetch/Request.idl (right):
> 
>
https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/fetch/Request.idl:25: "unsafe-url"
> On 2016/04/18 09:21:27, estark wrote:
> > Does this need to include the newly added
> > "no-referrer-when-downgrade-origin-when-cross-origin" value? Or does it only
> > need to include official spec'ed non-experimental values?
> 
> I'd like to not include no-referrer-when-downgrade-origin-when-cross-origin.

can you still pass that policy in and read it out if the runtime flag is
enabled?

[yhirano, 2016-04-21 01:57:40]

On 2016/04/20 14:20:48, jochen wrote:
> On 2016/04/19 at 14:24:10, yhirano wrote:
> >
>
https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/modules/fetch/Request.idl (right):
> > 
> >
>
https://codereview.chromium.org/1844413006/diff/210001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/modules/fetch/Request.idl:25: "unsafe-url"
> > On 2016/04/18 09:21:27, estark wrote:
> > > Does this need to include the newly added
> > > "no-referrer-when-downgrade-origin-when-cross-origin" value? Or does it
only
> > > need to include official spec'ed non-experimental values?
> > 
> > I'd like to not include no-referrer-when-downgrade-origin-when-cross-origin.
> 
> can you still pass that policy in and read it out if the runtime flag is
> enabled?

Enum values are not checked in the IDL generated code and they don't affect
actual behavior. I throw an exception in RequestInit.cpp manually.

[jochen (gone - plz use gerrit), 2016-04-21 04:02:53]

lgtm

[yhirano, 2016-04-25 06:21:34]

estark@, mkwst@, do you have any comments?

[estark, 2016-04-25 22:49:52]

None from me, lgtm

[estark, 2016-04-25 22:49:53]

None from me, lgtm

[Mike West, 2016-04-26 07:54:57]

lgtm, though you don't need it. :)

[yhirano, 2016-04-26 11:04:17]

Thank you.

[yhirano, 2016-04-26 11:04:23]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-04-26 11:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1844413006/#ps310001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-26 11:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844413006/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844413006/310001

[commit-bot: I haz the power, 2016-04-26 12:22:59]

Description was changed from

==========
Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
==========

to

==========
Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
==========

[commit-bot: I haz the power, 2016-04-26 12:23:01]

Committed patchset #7 (id:310001)

[commit-bot: I haz the power, 2016-04-26 12:24:28]

Description was changed from

==========
Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385
==========

to

==========
Support ReferrerPolicy in Fetch API

This CL consists of the following:
 - Add Request.referrerPolicy property.
 - Enable referrerPolicy setting in the Request construction.
 - Pass the referrer policy as part of a request from the page to the
   service worker.

Intent to Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7GYNDnQHRCs

BUG=532385

Committed: https://crrev.com/a8e98a61a6144db6a2b45baaff9eeb8930f0296f
Cr-Commit-Position: refs/heads/master@{#389753}
==========

[commit-bot: I haz the power, 2016-04-26 12:24:30]

Patchset 7 (id:??) landed as
https://crrev.com/a8e98a61a6144db6a2b45baaff9eeb8930f0296f
Cr-Commit-Position: refs/heads/master@{#389753}