Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1844413003: Fix the encoding of iso-8859-8-and-isolated*html files (Closed)

Created:
4 years, 8 months ago by jungshik at Google
Modified:
4 years, 8 months ago
Reviewers:
kojii
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the encoding of iso-8859-8-and-isolated*html files These files are supposed to be in ISO-8859-8, but they're actually in UTF-8. ./fast/text/international/iso-8859-8-and-isolate.html ./fast/text/international/iso-8859-8-and-isolate-expected.html This CL will be landed manually because rietveld/CQ cannot handle non-UTF-8 text files. It's uploaded to rietveld for the record, but note that files are messed up when viewed in rietveld. The ground truth is what's actually in the tree (landed manually). Three characters in the test files are U+05D2, U+05E7, U+05DB encoded in ISO-8859-8 (0xE2, 0xF7, 0xEB). TBR=kojii@chromium.org BUG=597517, 559257 Committed: https://chromium.googlesource.com/chromium/src/+/cbc9587ad7879f62f4841697f0c134ce80d0384d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/text/international/iso-8859-8-and-isolate.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/iso-8859-8-and-isolate-expected.html View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jungshik at Google
kojii, FYI. I've landed manually this.
4 years, 8 months ago (2016-03-31 18:43:44 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cbc9587ad7879f62f4841697f0c134ce80d0384d Cr-Commit-Position: refs/heads/master@{#384344}
4 years, 8 months ago (2016-03-31 18:45:14 UTC) #4
jungshik at Google
Committed patchset #1 (id:1) manually as cbc9587ad7879f62f4841697f0c134ce80d0384d (presubmit successful).
4 years, 8 months ago (2016-03-31 18:45:46 UTC) #6
kojii
4 years, 8 months ago (2016-04-05 03:35:14 UTC) #7
Message was sent while issue was closed.
lgtm, thanks for doing this.

Powered by Google App Engine
This is Rietveld 408576698