src/objects-inl.h - Issue 1844413002: Use EmbedderHeapTracer instead of object grouping when trace_embedder_heap flag is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1844413002: Use EmbedderHeapTracer instead of object grouping when trace_embedder_heap flag is set (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Remove flag, presence of heap tracer is enough Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index e1a44e746106e5aebd5b4819b08cd542c4f4ccdd..c1712491c3b2a274bc0a87b4e2651da22c824415 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1999,6 +1999,7 @@ int JSObject::GetHeaderSize(InstanceType type) {

// field operations considerably on average.

if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize;

switch (type) {

+ case JS_API_OBJECT_TYPE:

case JS_SPECIAL_API_OBJECT_TYPE:

return JSObject::kHeaderSize;

case JS_GENERATOR_OBJECT_TYPE:

« src/heap/mark-compact.cc ('K') | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »