Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: src/heap/mark-compact.h

Issue 1844413002: Use EmbedderHeapTracer instead of object grouping when trace_embedder_heap flag is set (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove flag, presence of heap tracer is enough Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/mark-compact.h
diff --git a/src/heap/mark-compact.h b/src/heap/mark-compact.h
index cd207bcda27ba792ec2291abead68006c86932be..b036c20ca377dc972f5345bd1da3fa0bcd747e53 100644
--- a/src/heap/mark-compact.h
+++ b/src/heap/mark-compact.h
@@ -577,6 +577,10 @@ class MarkCompactCollector {
return nullptr;
}
+ std::vector<std::pair<Value*, Value*>>& wrappers_to_trace() {
+ return wrappers_to_trace_;
+ }
+
private:
class EvacuateNewSpaceVisitor;
class EvacuateOldSpaceVisitor;
@@ -678,8 +682,8 @@ class MarkCompactCollector {
// or overflowed in the heap. This respects references only considered in
// the final atomic marking pause including the following:
// - Processing of objects reachable through Harmony WeakMaps.
- // - Objects reachable due to host application logic like object groups
- // or implicit references' groups.
+ // - Objects reachable due to host application logic like object groups,
+ // implicit references' groups, or embedder heap tracing.
void ProcessEphemeralMarking(ObjectVisitor* visitor,
bool only_process_harmony_weak_collections);
@@ -813,6 +817,8 @@ class MarkCompactCollector {
base::VirtualMemory* marking_deque_memory_;
size_t marking_deque_memory_committed_;
MarkingDeque marking_deque_;
+ std::vector<std::pair<Value*, Value*>> wrappers_to_trace_;
+
CodeFlusher* code_flusher_;
bool have_code_to_deoptimize_;

Powered by Google App Engine
This is Rietveld 408576698