Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Side by Side Diff: src/objects-inl.h

Issue 1844413002: Use EmbedderHeapTracer instead of object grouping when trace_embedder_heap flag is set (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Move logic from heap to mark compact Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 1981 matching lines...) Expand 10 before | Expand all | Expand 10 after
1992 1992
1993 int JSObject::GetHeaderSize() { return GetHeaderSize(map()->instance_type()); } 1993 int JSObject::GetHeaderSize() { return GetHeaderSize(map()->instance_type()); }
1994 1994
1995 1995
1996 int JSObject::GetHeaderSize(InstanceType type) { 1996 int JSObject::GetHeaderSize(InstanceType type) {
1997 // Check for the most common kind of JavaScript object before 1997 // Check for the most common kind of JavaScript object before
1998 // falling into the generic switch. This speeds up the internal 1998 // falling into the generic switch. This speeds up the internal
1999 // field operations considerably on average. 1999 // field operations considerably on average.
2000 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize; 2000 if (type == JS_OBJECT_TYPE) return JSObject::kHeaderSize;
2001 switch (type) { 2001 switch (type) {
2002 case JS_API_OBJECT_TYPE:
2002 case JS_SPECIAL_API_OBJECT_TYPE: 2003 case JS_SPECIAL_API_OBJECT_TYPE:
2003 return JSObject::kHeaderSize; 2004 return JSObject::kHeaderSize;
2004 case JS_GENERATOR_OBJECT_TYPE: 2005 case JS_GENERATOR_OBJECT_TYPE:
2005 return JSGeneratorObject::kSize; 2006 return JSGeneratorObject::kSize;
2006 case JS_MODULE_TYPE: 2007 case JS_MODULE_TYPE:
2007 return JSModule::kSize; 2008 return JSModule::kSize;
2008 case JS_GLOBAL_PROXY_TYPE: 2009 case JS_GLOBAL_PROXY_TYPE:
2009 return JSGlobalProxy::kSize; 2010 return JSGlobalProxy::kSize;
2010 case JS_GLOBAL_OBJECT_TYPE: 2011 case JS_GLOBAL_OBJECT_TYPE:
2011 return JSGlobalObject::kSize; 2012 return JSGlobalObject::kSize;
(...skipping 5789 matching lines...) Expand 10 before | Expand all | Expand 10 after
7801 #undef WRITE_INT64_FIELD 7802 #undef WRITE_INT64_FIELD
7802 #undef READ_BYTE_FIELD 7803 #undef READ_BYTE_FIELD
7803 #undef WRITE_BYTE_FIELD 7804 #undef WRITE_BYTE_FIELD
7804 #undef NOBARRIER_READ_BYTE_FIELD 7805 #undef NOBARRIER_READ_BYTE_FIELD
7805 #undef NOBARRIER_WRITE_BYTE_FIELD 7806 #undef NOBARRIER_WRITE_BYTE_FIELD
7806 7807
7807 } // namespace internal 7808 } // namespace internal
7808 } // namespace v8 7809 } // namespace v8
7809 7810
7810 #endif // V8_OBJECTS_INL_H_ 7811 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698