|
|
Chromium Code Reviews
DescriptionDon't run android lint on third_party/android_swipe_refresh
BUG=599052
Committed: https://crrev.com/869ed1705425ef599bc733eb059ae36df2d34bf1
Cr-Commit-Position: refs/heads/master@{#384342}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 24 (10 generated)
agrieve@chromium.org changed reviewers: + tedchoc@chromium.org
lgtm
On 2016/03/31 16:04:00, Ted C wrote: > lgtm and I approve of this donut themed code review
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
dfalcantara@chromium.org changed reviewers: + dfalcantara@chromium.org
Does it make sense to tack on this one? org/chromium/net/test/EmbeddedTestServerImpl.class Call requires API level 18 (current min is 16): `android.os.HandlerThread#quitSafely`: NewApi [warning] My compile failed after I applied your patch and tried to compile locally.
Eh, I'm coordinating with jbudorick on that. Seems like his patch landed 3 months ago and is only triggering the lint failure now.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Don't run android lint on third_party/android_swipe_refresh BUG=599052 ========== to ========== Don't run android lint on third_party/android_swipe_refresh BUG=599052 Committed: https://crrev.com/869ed1705425ef599bc733eb059ae36df2d34bf1 Cr-Commit-Position: refs/heads/master@{#384342} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/869ed1705425ef599bc733eb059ae36df2d34bf1 Cr-Commit-Position: refs/heads/master@{#384342} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
