Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1844383002: 🍩 Don't run android lint on third_party/android_swipe_refresh (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Ted C, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run android lint on third_party/android_swipe_refresh BUG=599052 Committed: https://crrev.com/869ed1705425ef599bc733eb059ae36df2d34bf1 Cr-Commit-Position: refs/heads/master@{#384342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/android_swipe_refresh/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (10 generated)
agrieve
4 years, 8 months ago (2016-03-31 15:46:34 UTC) #2
Ted C
lgtm
4 years, 8 months ago (2016-03-31 16:04:00 UTC) #3
Ted C
On 2016/03/31 16:04:00, Ted C wrote: > lgtm and I approve of this donut themed ...
4 years, 8 months ago (2016-03-31 16:04:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
4 years, 8 months ago (2016-03-31 16:58:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/167098)
4 years, 8 months ago (2016-03-31 17:03:14 UTC) #8
gone
Does it make sense to tack on this one? org/chromium/net/test/EmbeddedTestServerImpl.class Call requires API level 18 ...
4 years, 8 months ago (2016-03-31 17:12:29 UTC) #10
gone
Eh, I'm coordinating with jbudorick on that. Seems like his patch landed 3 months ago ...
4 years, 8 months ago (2016-03-31 17:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
4 years, 8 months ago (2016-03-31 17:25:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/167137)
4 years, 8 months ago (2016-03-31 17:29:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
4 years, 8 months ago (2016-03-31 17:58:32 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/167183)
4 years, 8 months ago (2016-03-31 18:02:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844383002/1
4 years, 8 months ago (2016-03-31 18:29:22 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 18:38:06 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:42:54 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/869ed1705425ef599bc733eb059ae36df2d34bf1
Cr-Commit-Position: refs/heads/master@{#384342}

Powered by Google App Engine
This is Rietveld 408576698