components/test_runner/test_plugin.cc - Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_plugin.cc

Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rm-alphadepthetc

Patch Set: move-attributes: webstring Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/renderer_blink_platform_impl.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_plugin.cc

diff --git a/components/test_runner/test_plugin.cc b/components/test_runner/test_plugin.cc

index 2efbb3f8d991eb54dc349cb64b4583bf54d84aaa..7e0b2d637e1ff8a33db10dd0b36da6cf5987b1f4 100644

--- a/components/test_runner/test_plugin.cc

+++ b/components/test_runner/test_plugin.cc

@@ -24,6 +24,7 @@

#include "third_party/WebKit/public/platform/WebTaskRunner.h"

#include "third_party/WebKit/public/platform/WebThread.h"

#include "third_party/WebKit/public/platform/WebTraceLocation.h"

+#include "third_party/WebKit/public/platform/WebURL.h"

#include "third_party/WebKit/public/web/WebFrame.h"

#include "third_party/WebKit/public/web/WebInputEvent.h"

#include "third_party/WebKit/public/web/WebKit.h"

@@ -173,11 +174,12 @@ TestPlugin::~TestPlugin() {

}

bool TestPlugin::initialize(blink::WebPluginContainer* container) {

- blink::WebGraphicsContext3D::Attributes attrs;

+ blink::Platform::ContextAttributes attrs;

+ blink::WebURL url("chrome://TestPlugin::initialize");

piman 2016/04/01 00:44:09 nit: How about container->element().document().url

danakj 2016/04/01 00:45:23 I was hoping to never have a null URL anymore. The

blink::Platform::GraphicsInfo gl_info;

context_provider_ = make_scoped_ptr(

blink::Platform::current()->createOffscreenGraphicsContext3DProvider(

- attrs, nullptr, &gl_info));

+ attrs, url, nullptr, &gl_info));

context_ = context_provider_ ? context_provider_->context3d() : nullptr;

gl_ = context_provider_ ? context_provider_->contextGL() : nullptr;

« no previous file with comments | « no previous file | content/renderer/renderer_blink_platform_impl.h » ('j') | third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h » ('J')