third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp - Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rm-alphadepthetc

Patch Set: move-attributes: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp b/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

index c4fd16b05f8034e73af7c2b2f1339b871d87b973..af9f9e73ef145aeb5f5318b647a16d6649bc4bc2 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.cpp

@@ -21,13 +21,12 @@ WebGLContextAttributes toWebGLContextAttributes(const CanvasContextCreationAttri

return result;

}

-WebGraphicsContext3D::Attributes toWebGraphicsContext3DAttributes(const WebGLContextAttributes& attrs, const WebString& topDocumentURL, unsigned webGLVersion)

+Platform::ContextAttributes toPlatformContextAttributes(const WebGLContextAttributes& attrs, unsigned webGLVersion)

{

- WebGraphicsContext3D::Attributes result;

+ Platform::ContextAttributes result;

result.failIfMajorPerformanceCaveat = attrs.failIfMajorPerformanceCaveat();

result.shareResources = false;

result.preferDiscreteGPU = true;

- result.topDocumentURL = topDocumentURL;

result.webGLVersion = webGLVersion;

return result;

}