content/renderer/renderer_blink_platform_impl.cc - Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.cc

Issue 1844363003: Move WebGraphicsContext3D::Attributes to Platform::ContextAttributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rm-alphadepthetc

Patch Set: move-attributes: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/renderer_blink_platform_impl.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLContextAttributeHelpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/renderer_blink_platform_impl.cc

diff --git a/content/renderer/renderer_blink_platform_impl.cc b/content/renderer/renderer_blink_platform_impl.cc

index f5d9a853e1d2a6af4a79e2813df8c9c2a6dbf20f..2d459fed873670bb2d46fff3866b496baf36a5d7 100644

--- a/content/renderer/renderer_blink_platform_impl.cc

+++ b/content/renderer/renderer_blink_platform_impl.cc

@@ -1006,7 +1006,8 @@ static void Collect3DContextInformationOnFailure(

blink::WebGraphicsContext3DProvider*

RendererBlinkPlatformImpl::createOffscreenGraphicsContext3DProvider(

- const blink::WebGraphicsContext3D::Attributes& web_attributes,

+ const blink::Platform::ContextAttributes& web_attributes,

+ const blink::WebURL& top_document_web_url,

blink::WebGraphicsContext3DProvider* share_provider,

blink::Platform::GraphicsInfo* gl_info) {

DCHECK(gl_info);

@@ -1048,13 +1049,13 @@ RendererBlinkPlatformImpl::createOffscreenGraphicsContext3DProvider(

gfx::GpuPreference gpu_preference = web_attributes.preferDiscreteGPU

? gfx::PreferDiscreteGpu

: gfx::PreferIntegratedGpu;

- GURL url = blink::WebStringToGURL(web_attributes.topDocumentURL);

WebGraphicsContext3DCommandBufferImpl::SharedMemoryLimits limits;

scoped_ptr<WebGraphicsContext3DCommandBufferImpl> context(

WebGraphicsContext3DCommandBufferImpl::CreateOffscreenContext(

gpu_channel_host.get(), attributes, gpu_preference, share_resources,

- automatic_flushes, url, limits, share_context));

+ automatic_flushes, GURL(top_document_web_url), limits,

+ share_context));

scoped_refptr<ContextProviderCommandBuffer> provider =

ContextProviderCommandBuffer::Create(std::move(context),

RENDERER_MAINTHREAD_CONTEXT);