Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: android_webview/native/aw_contents.cc

Issue 1844343005: WIP - Control the lifetime of RenderThreadManager from Java. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rework; BVR still needs to be informed of the SRS pointer. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index ce8720421e4b31a34cf0aca43938dc5328adb372..c0ca5c87fc978646003c181177ffb1737a2be1a2 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -16,7 +16,6 @@
#include "android_webview/browser/net_disk_cache_remover.h"
#include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h"
#include "android_webview/browser/scoped_app_gl_state_restore.h"
-#include "android_webview/browser/shared_renderer_state.h"
#include "android_webview/common/aw_hit_test_data.h"
#include "android_webview/common/aw_switches.h"
#include "android_webview/common/devtools_instrumentation.h"
@@ -181,10 +180,7 @@ AwBrowserPermissionRequestDelegate* AwBrowserPermissionRequestDelegate::FromID(
}
AwContents::AwContents(std::unique_ptr<WebContents> web_contents)
- : shared_renderer_state_(
- this,
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI)),
- browser_view_renderer_(
+ : browser_view_renderer_(
this,
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI),
base::CommandLine::ForCurrentProcess()->HasSwitch(
@@ -192,7 +188,6 @@ AwContents::AwContents(std::unique_ptr<WebContents> web_contents)
web_contents_(std::move(web_contents)),
renderer_manager_key_(GLViewRendererManager::GetInstance()->NullKey()) {
base::subtle::NoBarrier_AtomicIncrement(&g_instance_count, 1);
- browser_view_renderer_.SetSharedRendererState(&shared_renderer_state_);
icon_helper_.reset(new IconHelper(web_contents_.get()));
icon_helper_->SetListener(this);
web_contents_->SetUserData(android_webview::kAwContentsUserDataKey,
@@ -363,12 +358,6 @@ jint GetNativeInstanceCount(JNIEnv* env, const JavaParamRef<jclass>&) {
return base::subtle::NoBarrier_Load(&g_instance_count);
}
-jlong AwContents::GetAwDrawGLViewContext(JNIEnv* env,
- const JavaParamRef<jobject>& obj) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- return reinterpret_cast<intptr_t>(&shared_renderer_state_);
-}
-
namespace {
void DocumentHasImagesCallback(const ScopedJavaGlobalRef<jobject>& message,
bool has_images) {
@@ -895,7 +884,6 @@ void AwContents::OnAttachedToWindow(JNIEnv* env,
void AwContents::OnDetachedFromWindow(JNIEnv* env,
const JavaParamRef<jobject>& obj) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- shared_renderer_state_.DeleteHardwareRendererOnUI();
browser_view_renderer_.OnDetachedFromWindow();
}
@@ -1234,9 +1222,6 @@ void AwContents::TrimMemory(JNIEnv* env,
if (level < TRIM_MEMORY_BACKGROUND && visible)
return;
- if (level >= TRIM_MEMORY_MODERATE)
- shared_renderer_state_.DeleteHardwareRendererOnUI();
-
browser_view_renderer_.TrimMemory();
}

Powered by Google App Engine
This is Rietveld 408576698