SkWStream::writeText inlined.

SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1844343004

Committed: https://skia.googlesource.com/skia/+/cbc060a70007bcdcc180d74b552f30104c88a805

[hal.canary, 2016-03-31 19:00:52]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-03-31 19:01:10]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-01 14:38:16]

halcanary@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[hal.canary, 2016-04-01 14:38:16]

PTAL

[hal.canary, 2016-04-01 15:18:10]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bungeman-skia, 2016-04-01 15:19:18]

lgtm

https://codereview.chromium.org/1844343004/diff/1/include/core/SkStream.h
File include/core/SkStream.h (right):

https://codereview.chromium.org/1844343004/diff/1/include/core/SkStream.h#new...
include/core/SkStream.h:205: return this->write(text, strlen(text));
The win here appears to be mostly that the compiler can now pre-compute
strlen(text) when text is a compile time constant string.

[bungeman-skia, 2016-04-01 15:19:39]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 15:19:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844343004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844343004/1

[commit-bot: I haz the power, 2016-04-01 15:33:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 15:33:31]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-04-02 14:02:17]

How does this change affect the speed of generating a PDF doc, not just this
nanobench?

[hal.canary, 2016-04-05 18:06:31]

On 2016/04/02 14:02:17, reed1 wrote:
> How does this change affect the speed of generating a PDF doc, not just this
> nanobench?

That's much harder to measure, due to the high variance.

After some experiments with dm, I get a run time delta of -0.8%±0.04%.

[hal.canary, 2016-04-05 18:07:39]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-05 18:07:51]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.


GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[hal.canary, 2016-04-11 21:26:43]

On 2016/04/05 18:06:31, Hal Canary wrote:
> On 2016/04/02 14:02:17, reed1 wrote:
> > How does this change affect the speed of generating a PDF doc, not just this
> > nanobench?
> 
> That's much harder to measure, due to the high variance.
> 
> After some experiments with dm, I get a run time delta of -0.8%±0.04%.

(That's a ~1% improvement; let's land.)

[reed1, 2016-04-12 01:38:11]

api lgtm

[hal.canary, 2016-04-12 02:27:24]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2016-04-12 02:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1844343004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1844343004/1

[commit-bot: I haz the power, 2016-04-12 02:41:51]

Description was changed from

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SkWStream::writeText inlined.

Motivation: This function is used throughout SkPDF.

Note that the compiler can usually inline the result of strlen() for literal
strings.

Before:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 24.2ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              6.10  	WStreamWriteText	nonrendering

After:
    out/Release/nanobench -m WStreamWriteText -q
        Timer overhead: 23.9ns
        ! -> high variance, ? -> moderate variance
            micros   	bench
              2.51  	WStreamWriteText	nonrendering

PDF runtime change: -0.8% ±0.04%.

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/cbc060a70007bcdcc180d74b552f30104c88a805
==========

[commit-bot: I haz the power, 2016-04-12 02:41:52]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cbc060a70007bcdcc180d74b552f30104c88a805