Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1844343002:
Gerrit git cl: implement "git cl land". (Closed)
|
Created:
4 years, 8 months ago by tandrii(chromium) Modified:
4 years, 8 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
DescriptionGerrit git cl: implement "git cl land".
R=sergiyb@chromium.org,andybons@chromium.org
BUG=579180
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299589
Patch Set 1 #Patch Set 2 : added checks for diff between local and remote #
Total comments: 13
Patch Set 3 : review #Patch Set 4 : review-rebase artifacts #Patch Set 5 : argh, rebase #Messages
Total messages: 16 (8 generated)
The CQ bit was checked by tandrii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844343002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL
lgtm with nits https://codereview.chromium.org/1844343002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1679 git_cl.py:1679: print('WARNING: local branch contents differs from latest uploaded ' s/differs/differ https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1700 git_cl.py:1700: _CODEREVIEW_IMPLEMENTATIONS = { _CODE_REVIEW_IMPLEMENTATIONS https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3161 git_cl.py:3161: which pushe upstream and closes the issue automatically and atomically. s/pushe/pushes https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3163 git_cl.py:3163: Otherwise (in case of Rietvled): Rietveld https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit s/has ability/has the ability https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit s/change commit message/change the commit message https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3195 git_cl.py:3195: '-c CONTRIBUTOR option is not support for Gerrit.\n' s/not support/not supported
Thanks done all but one. https://codereview.chromium.org/1844343002/diff/20001/git_cl.py File git_cl.py (right): https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1679 git_cl.py:1679: print('WARNING: local branch contents differs from latest uploaded ' On 2016/03/31 15:50:19, Bons wrote: > s/differs/differ Done. https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1700 git_cl.py:1700: _CODEREVIEW_IMPLEMENTATIONS = { On 2016/03/31 15:50:20, Bons wrote: > _CODE_REVIEW_IMPLEMENTATIONS disagree on the basis of other "codereview" uses in this file, though there is one use with "_" separation :( https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3161 git_cl.py:3161: which pushe upstream and closes the issue automatically and atomically. On 2016/03/31 15:50:20, Bons wrote: > s/pushe/pushes Done. https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3163 git_cl.py:3163: Otherwise (in case of Rietvled): On 2016/03/31 15:50:20, Bons wrote: > Rietveld Done. https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit On 2016/03/31 15:50:20, Bons wrote: > s/change commit message/change the commit message Done. https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit On 2016/03/31 15:50:19, Bons wrote: > s/has ability/has the ability Done.
On 2016/03/31 15:55:02, tandrii(chromium) wrote: > Thanks done all but one. > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py > File git_cl.py (right): > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1679 > git_cl.py:1679: print('WARNING: local branch contents differs from latest > uploaded ' > On 2016/03/31 15:50:19, Bons wrote: > > s/differs/differ > > Done. > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode1700 > git_cl.py:1700: _CODEREVIEW_IMPLEMENTATIONS = { > On 2016/03/31 15:50:20, Bons wrote: > > _CODE_REVIEW_IMPLEMENTATIONS > > disagree on the basis of other "codereview" uses in this file, though there is > one use with "_" separation :( > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3161 > git_cl.py:3161: which pushe upstream and closes the issue automatically and > atomically. > On 2016/03/31 15:50:20, Bons wrote: > > s/pushe/pushes > > Done. > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3163 > git_cl.py:3163: Otherwise (in case of Rietvled): > On 2016/03/31 15:50:20, Bons wrote: > > Rietveld > > Done. > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 > git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit > On 2016/03/31 15:50:20, Bons wrote: > > s/change commit message/change the commit message > > Done. > > https://codereview.chromium.org/1844343002/diff/20001/git_cl.py#newcode3190 > git_cl.py:3190: # Besides, Gerrit has ability to change commit message on submit > On 2016/03/31 15:50:19, Bons wrote: > > s/has ability/has the ability > > Done. lgtm
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org Link to the patchset: https://codereview.chromium.org/1844343002/#ps60001 (title: "review-rebase artifacts")
The CQ bit was unchecked by tandrii@chromium.org
The CQ bit was checked by tandrii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from andybons@chromium.org Link to the patchset: https://codereview.chromium.org/1844343002/#ps80001 (title: "argh, rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844343002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844343002/80001
Message was sent while issue was closed.
Description was changed from ========== Gerrit git cl: implement "git cl land". R=sergiyb@chromium.org,andybons@chromium.org BUG=579180 ========== to ========== Gerrit git cl: implement "git cl land". R=sergiyb@chromium.org,andybons@chromium.org BUG=579180 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299589 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299589 |
