Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 184433007: Remove wall time from NotifyAnimationStarted and NotifyAnimationFinished. (Closed)

Created:
6 years, 9 months ago by mithro-old
Modified:
6 years, 9 months ago
Reviewers:
danakj, jamesr, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_wall_time_step2
Visibility:
Public.

Description

Remove wall time from NotifyAnimationStarted and NotifyAnimationFinished. With the change to Blink only needing the monotonic time the wall time can be removed. DEPS=185633002,185643002 BUG=299945 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255888

Patch Set 1 : #

Patch Set 2 : Fixing unittests for API update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -57 lines) Patch
M cc/animation/animation_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/animation/layer_animation_controller.h View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 4 chunks +8 lines, -10 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 12 chunks +12 lines, -18 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 9 chunks +0 lines, -10 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
mithro-old
Hi guys, A small CL to remove wall time from the animation delegate. Will rebase ...
6 years, 9 months ago (2014-03-05 05:16:34 UTC) #1
ajuma
This looks good, but the same changes will need to be made to cc unit ...
6 years, 9 months ago (2014-03-05 14:12:41 UTC) #2
mithro-old
On 2014/03/05 14:12:41, ajuma wrote: > This looks good, but the same changes will need ...
6 years, 9 months ago (2014-03-06 02:18:07 UTC) #3
ajuma
On 2014/03/06 02:18:07, mithro wrote: > On 2014/03/05 14:12:41, ajuma wrote: > > This looks ...
6 years, 9 months ago (2014-03-06 02:22:03 UTC) #4
mithro-old
On 2014/03/06 02:22:03, ajuma wrote: > On 2014/03/06 02:18:07, mithro wrote: > > On 2014/03/05 ...
6 years, 9 months ago (2014-03-06 02:35:55 UTC) #5
jamesr
lgtm
6 years, 9 months ago (2014-03-06 03:47:41 UTC) #6
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-07 14:58:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/184433007/40001
6 years, 9 months ago (2014-03-07 14:58:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 15:00:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel
6 years, 9 months ago (2014-03-07 15:00:23 UTC) #10
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-08 09:36:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/184433007/40001
6 years, 9 months ago (2014-03-08 10:39:31 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:04:52 UTC) #13
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234311
6 years, 9 months ago (2014-03-08 14:04:52 UTC) #14
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-08 15:36:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/184433007/40001
6 years, 9 months ago (2014-03-08 15:36:11 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 16:24:03 UTC) #17
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234440
6 years, 9 months ago (2014-03-08 16:24:04 UTC) #18
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 9 months ago (2014-03-10 01:33:21 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/184433007/40001
6 years, 9 months ago (2014-03-10 01:33:31 UTC) #20
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 06:39:19 UTC) #21
Message was sent while issue was closed.
Change committed as 255888

Powered by Google App Engine
This is Rietveld 408576698