Give the browser window's content view a CALayers

Give the browser window's content view a CALayers

This is necessary to ensure correct ordering of the CALayers
of the child NSViews of the window's content view. Most of
the time the NSViews appeared in the correct order, but
not all of the time (especially on 10.6). This fixes that issue.

Remove code to dynamically do this when entering and leaving
presentation mode.

Update the FastResizeView to host a white CALayer instead of
trying to call drawRect, and make the NSView opaque.

This caused a performance drop last time it was tried, but other
performance fixes, and the FastResizeView fix might make it so
that this does not have an appreciable performance impact.

BUG=348490
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255150

[ccameron, 2014-03-05 02:35:20]

While working on this, I diagrammed the NSView hierarchy. It may be useful when
verifying the patch.
https://docs.google.com/a/google.com/drawings/d/1irLL6LjWG2HI0hT3z3Euy6oXDoAG...

[Avi (use Gerrit), 2014-03-05 03:19:27]

Good luck with the performance hit.

Wondering about the helper-ness of the functions.

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
File chrome/browser/ui/cocoa/nsview_additions.h (right):

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
chrome/browser/ui/cocoa/nsview_additions.h:48: -
(void)cr_setHostsSolidWhiteLayer;
This is only used once; why does it get its own helper?

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
File chrome/browser/ui/cocoa/nsview_additions.mm (right):

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
chrome/browser/ui/cocoa/nsview_additions.mm:127: CALayer* layer = [[CALayer
alloc] init];
This looks like it leaks. scoped_nsobject?

[ccameron, 2014-03-05 07:59:31]

Thanks -- patch updated

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
File chrome/browser/ui/cocoa/nsview_additions.h (right):

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
chrome/browser/ui/cocoa/nsview_additions.h:48: -
(void)cr_setHostsSolidWhiteLayer;
On 2014/03/05 03:19:28, Avi wrote:
> This is only used once; why does it get its own helper?

I had a vague preference for consolidating all of the command line queries in
one file, but that's a bit weak of a reason. Deleted.

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
File chrome/browser/ui/cocoa/nsview_additions.mm (right):

https://codereview.chromium.org/184433005/diff/1/chrome/browser/ui/cocoa/nsvi...
chrome/browser/ui/cocoa/nsview_additions.mm:127: CALayer* layer = [[CALayer
alloc] init];
On 2014/03/05 03:19:28, Avi wrote:
> This looks like it leaks. scoped_nsobject?

Yes, it does leak. The setLayer will take out a reference, so it can be released
immediately after.

[Avi (use Gerrit), 2014-03-05 16:17:02]

LGTM with change.

https://codereview.chromium.org/184433005/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/184433005/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:28: CALayer* layer = [[CALayer
alloc] init];
scoped_nsobject

[ccameron, 2014-03-05 18:18:40]

Thanks!

https://codereview.chromium.org/184433005/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/fast_resize_view.mm (right):

https://codereview.chromium.org/184433005/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/fast_resize_view.mm:28: CALayer* layer = [[CALayer
alloc] init];
On 2014/03/05 16:17:02, Avi wrote:
> scoped_nsobject

Done.

[ccameron, 2014-03-05 18:18:46]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-05 18:20:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/184433005/60001

[commit-bot: I haz the power, 2014-03-05 21:08:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:09:00]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[ccameron, 2014-03-05 21:15:38]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-03-05 21:16:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/184433005/60001

[commit-bot: I haz the power, 2014-03-05 21:18:58]

Change committed as 255150