Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1844293006: Fix DCHECK to assert always (Closed)

Created:
4 years, 8 months ago by Raymond Toy
Modified:
4 years, 8 months ago
Reviewers:
haraken, hongchan
CC:
chromium-reviews, blink-reviews, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECK to assert always Change DCHECK(1) to DCHECK(0) so we always assert because we should never reach this code. BUG=597359 TEST=none Committed: https://crrev.com/bd6ff6faa76af34b6478396e8ca6aea0f746029f Cr-Commit-Position: refs/heads/master@{#384717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/webaudio/AudioNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Raymond Toy
PTAL
4 years, 8 months ago (2016-04-01 18:17:55 UTC) #2
hongchan
lgtm
4 years, 8 months ago (2016-04-01 19:44:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844293006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844293006/1
4 years, 8 months ago (2016-04-01 20:22:29 UTC) #5
haraken
LGTM
4 years, 8 months ago (2016-04-01 22:58:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:45:43 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:48:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd6ff6faa76af34b6478396e8ca6aea0f746029f
Cr-Commit-Position: refs/heads/master@{#384717}

Powered by Google App Engine
This is Rietveld 408576698