Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/heap/heap.cc

Issue 1844293005: [heap] Remove unused step_size_in_bytes in AdvanceIncrementalMarking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/ast/scopeinfo.h" 9 #include "src/ast/scopeinfo.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 910 matching lines...) Expand 10 before | Expand all | Expand 10 after
921 kGCCallbackFlagSynchronousPhantomCallbackProcessing); 921 kGCCallbackFlagSynchronousPhantomCallbackProcessing);
922 } 922 }
923 } else { 923 } else {
924 // Incremental marking is turned on an has already been started. 924 // Incremental marking is turned on an has already been started.
925 925
926 // TODO(mlippautz): Compute the time slice for incremental marking based on 926 // TODO(mlippautz): Compute the time slice for incremental marking based on
927 // memory pressure. 927 // memory pressure.
928 double deadline = MonotonicallyIncreasingTimeInMs() + 928 double deadline = MonotonicallyIncreasingTimeInMs() +
929 FLAG_external_allocation_limit_incremental_time; 929 FLAG_external_allocation_limit_incremental_time;
930 incremental_marking()->AdvanceIncrementalMarking( 930 incremental_marking()->AdvanceIncrementalMarking(
931 0, deadline, 931 deadline,
932 IncrementalMarking::StepActions(IncrementalMarking::GC_VIA_STACK_GUARD, 932 IncrementalMarking::StepActions(IncrementalMarking::GC_VIA_STACK_GUARD,
933 IncrementalMarking::FORCE_MARKING, 933 IncrementalMarking::FORCE_MARKING,
934 IncrementalMarking::FORCE_COMPLETION)); 934 IncrementalMarking::FORCE_COMPLETION));
935 } 935 }
936 } 936 }
937 937
938 938
939 void Heap::EnsureFillerObjectAtTop() { 939 void Heap::EnsureFillerObjectAtTop() {
940 // There may be an allocation memento behind every object in new space. 940 // There may be an allocation memento behind every object in new space.
941 // If we evacuate a not full new space or if we are on the last page of 941 // If we evacuate a not full new space or if we are on the last page of
(...skipping 5534 matching lines...) Expand 10 before | Expand all | Expand 10 after
6476 } 6476 }
6477 6477
6478 6478
6479 // static 6479 // static
6480 int Heap::GetStaticVisitorIdForMap(Map* map) { 6480 int Heap::GetStaticVisitorIdForMap(Map* map) {
6481 return StaticVisitorBase::GetVisitorId(map); 6481 return StaticVisitorBase::GetVisitorId(map);
6482 } 6482 }
6483 6483
6484 } // namespace internal 6484 } // namespace internal
6485 } // namespace v8 6485 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698