Chromium Code Reviews

Issue 1844293005: [heap] Remove unused step_size_in_bytes in AdvanceIncrementalMarking. (Closed)

Created:
4 years, 8 months ago by Hannes Payer (out of office)
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove unused step_size_in_bytes in AdvanceIncrementalMarking. BUG= Committed: https://crrev.com/3dc43a7550c7142c940681492e3f792dc91f0122 Cr-Commit-Position: refs/heads/master@{#35238}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+22 lines, -29 lines)
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments
M src/heap/incremental-marking.h View 1 chunk +4 lines, -7 lines 0 comments
M src/heap/incremental-marking.cc View 1 chunk +7 lines, -11 lines 0 comments
M src/heap/incremental-marking-job.cc View 2 chunks +5 lines, -5 lines 0 comments
M src/heap/memory-reducer.cc View 1 chunk +4 lines, -4 lines 0 comments
M test/cctest/heap/test-heap.cc View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 13 (6 generated)
Hannes Payer (out of office)
4 years, 8 months ago (2016-04-01 12:33:30 UTC) #2
Michael Lippautz
lgtm
4 years, 8 months ago (2016-04-01 12:45:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844293005/1
4 years, 8 months ago (2016-04-01 13:00:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/16029) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-01 13:03:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844293005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844293005/20001
4 years, 8 months ago (2016-04-04 12:36:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 13:00:40 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:01:56 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3dc43a7550c7142c940681492e3f792dc91f0122
Cr-Commit-Position: refs/heads/master@{#35238}

Powered by Google App Engine