Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1844283002: [heap] Remove store buffer top from roots (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
Reviewers:
ulan, Yang
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove store buffer top from roots Change x64 to use the external references like all other platforms. BUG=chromium:581076 LOG=N Committed: https://crrev.com/21f1dfe9169e7e0099141204961fccaf8798975a Cr-Commit-Position: refs/heads/master@{#35160}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -51 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/heap/heap.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/store-buffer.h View 1 chunk +10 lines, -4 lines 0 comments Download
M src/heap/store-buffer.cc View 4 chunks +11 lines, -10 lines 0 comments Download
D src/heap/store-buffer-inl.h View 1 chunk +0 lines, -20 lines 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Lippautz
PTAL, running perf bots to spot a potential caching issue.
4 years, 8 months ago (2016-03-31 08:51:56 UTC) #3
Yang
On 2016/03/31 08:51:56, Michael Lippautz wrote: > PTAL, running perf bots to spot a potential ...
4 years, 8 months ago (2016-03-31 09:55:14 UTC) #4
ulan
lgtm
4 years, 8 months ago (2016-03-31 10:48:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844283002/20001
4 years, 8 months ago (2016-03-31 10:50:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-03-31 11:15:23 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 11:16:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21f1dfe9169e7e0099141204961fccaf8798975a
Cr-Commit-Position: refs/heads/master@{#35160}

Powered by Google App Engine
This is Rietveld 408576698