Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm

Issue 1844243002: [CookieStore] Upgrading host-based deleting to predicate-based deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix IOS Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/storage_partition_impl_unittest.cc ('k') | ios/net/cookies/cookie_store_ios.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
diff --git a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
index c7f6990a856a259b2d463a6d47348313cc61e3df..856283f5779674537c89002e102f71a87eb46f0e 100644
--- a/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
+++ b/ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.mm
@@ -38,6 +38,7 @@
#include "ios/web/public/user_metrics.h"
#include "ios/web/public/web_thread.h"
#include "net/base/net_errors.h"
+#include "net/cookies/canonical_cookie.h"
#include "net/cookies/cookie_store.h"
#include "net/http/transport_security_state.h"
#include "net/ssl/channel_id_service.h"
@@ -64,6 +65,11 @@ CallbackList* GetOnBrowsingDataRemovedCallbacks() {
return g_on_browsing_data_removed_callbacks;
}
+bool DoesCookieMatchHost(const std::string& host,
+ const net::CanonicalCookie& cookie) {
+ return cookie.IsHostCookie() && cookie.IsDomainMatch(host);
+}
+
} // namespace
bool IOSChromeBrowsingDataRemover::is_removing_ = false;
@@ -482,8 +488,9 @@ void IOSChromeBrowsingDataRemover::ClearCookiesOnIOThread(
base::Bind(&IOSChromeBrowsingDataRemover::OnClearedCookies,
base::Unretained(this)));
} else {
- cookie_store->DeleteAllCreatedBetweenForHostAsync(
- delete_begin_, delete_end_, storage_url,
+ cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
+ delete_begin_, delete_end_,
+ base::Bind(&DoesCookieMatchHost, storage_url.host()),
base::Bind(&IOSChromeBrowsingDataRemover::OnClearedCookies,
base::Unretained(this)));
}
« no previous file with comments | « content/browser/storage_partition_impl_unittest.cc ('k') | ios/net/cookies/cookie_store_ios.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698