Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: content/browser/storage_partition_impl.cc

Issue 1844243002: [CookieStore] Upgrading host-based deleting to predicate-based deleting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added android changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/storage_partition_impl.cc
diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc
index e102445330aa80d3d0e18e50d1cca68e3514e013..a96770b1a3b07312ea1abe880e00742f86bcf66e 100644
--- a/content/browser/storage_partition_impl.cc
+++ b/content/browser/storage_partition_impl.cc
@@ -66,10 +66,10 @@ void ClearCookiesOnIOThread(
end,
base::Bind(&OnClearedCookies, callback));
} else {
- cookie_store->DeleteAllCreatedBetweenForHostAsync(
- begin,
- end,
- storage_origin, base::Bind(&OnClearedCookies, callback));
+ cookie_store->DeleteAllCreatedBetweenWithPredicateAsync(
Mike West 2016/04/01 07:40:52 Why do we only clear host cookies here? I understa
dmurph 2016/04/01 23:16:45 I have no idea. I suspect that we might be able to
+ begin, end,
+ net::CookieStore::CreatePredicateForHostCookies(storage_origin),
+ base::Bind(&OnClearedCookies, callback));
}
}

Powered by Google App Engine
This is Rietveld 408576698