Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: content/public/browser/utility_process_host.h

Issue 1844233003: Always allow ServiceRegistry to be used with UtilityProcessHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove scoped_ptr usage. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/utility_process_host.h
diff --git a/content/public/browser/utility_process_host.h b/content/public/browser/utility_process_host.h
index 1a903136f2651fb46d8c89ef3f4ec665aba64954..98cca9b3bbc17316aecf987e577dcf81df5b33f5 100644
--- a/content/public/browser/utility_process_host.h
+++ b/content/public/browser/utility_process_host.h
@@ -29,7 +29,7 @@ struct ChildProcessData;
// If you need multiple batches of work to be done in the process, use
// StartBatchMode(), then multiple calls to StartFooBar(p), then finish with
// EndBatchMode().
-// If you need to call Mojo services, use StartMojoMode() to start the child
+// If you need to call Mojo services, use Start() to start the child
// process and GetServiceRegistry() to get the service registry to connect to
// the child's Mojo services.
//
@@ -76,11 +76,10 @@ class UtilityProcessHost : public IPC::Sender {
virtual void SetEnv(const base::EnvironmentMap& env) = 0;
#endif
- // Starts the utility process in Mojo mode.
- virtual bool StartMojoMode() = 0;
+ // Starts the utility process.
+ virtual bool Start() = 0;
- // Returns the ServiceRegistry for this process. Will return nullptr if
- // the process was not started with StartMojoMode().
+ // Returns the ServiceRegistry for this process. Will never return nullptr.
virtual ServiceRegistry* GetServiceRegistry() = 0;
// Set the name of the process to appear in the task manager.

Powered by Google App Engine
This is Rietveld 408576698