Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1844233002: Add diagnostic printing to standalone/precompilation_test. (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add diagnostic printing to standalone/precompilation_test. This should help diagnose which step causes the flaky timeout failures on the buildbot. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c53ec0971baff642ac3e24a5cc6fed1af284a26d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tests/standalone/precompilation_dart2js_test.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M tests/standalone/precompilation_test.dart View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 8 months ago (2016-03-31 00:31:03 UTC) #2
rmacnak
lgtm
4 years, 8 months ago (2016-03-31 00:34:34 UTC) #3
Florian Schneider
4 years, 8 months ago (2016-03-31 00:38:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c53ec0971baff642ac3e24a5cc6fed1af284a26d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698