Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1844223005: Improve clarity of Physical Web onboarding interstitial message (Closed)

Created:
4 years, 8 months ago by mattreynolds
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve clarity of Physical Web onboarding interstitial message Previously: Chrome can now find and show you nearby web pages using Bluetooth. Chrome will scan for nearby pages when your device is unlocked. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome privacy settings. Now: Devices nearby you are broadcasting web pages over Bluetooth. Chrome will scan for nearby pages and display them when you wake up your device. These pages will go through a Google service to improve the quality of page results. You can control the Physical Web in Chrome Settings. This is a strings-only change. BUG=598106 Committed: https://crrev.com/fba5127254e67274c1c423db618a27233ef8175b Cr-Commit-Position: refs/heads/master@{#384999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mattreynolds
Hi Tommy, one more strings-only change. PTAL.
4 years, 8 months ago (2016-04-01 22:53:09 UTC) #3
nyquist
lgtm
4 years, 8 months ago (2016-04-01 23:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844223005/1
4 years, 8 months ago (2016-04-01 23:37:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844223005/1
4 years, 8 months ago (2016-04-04 20:10:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 20:56:27 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 20:57:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fba5127254e67274c1c423db618a27233ef8175b
Cr-Commit-Position: refs/heads/master@{#384999}

Powered by Google App Engine
This is Rietveld 408576698