third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp ('k') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 98b04285fcb22d795e62fbf56591a796e7734f21..e88a321b122720f0c590582e2d6479d71add509a 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -2511,8 +2511,8 @@ int WebViewImpl::textInputFlags()

if (!element)

return WebTextInputFlagNone;

- DEFINE_STATIC_LOCAL(AtomicString, autocompleteString, ("autocomplete", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(AtomicString, autocorrectString, ("autocorrect", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(AtomicString, autocompleteString, ("autocomplete"));

+ DEFINE_STATIC_LOCAL(AtomicString, autocorrectString, ("autocorrect"));

int flags = 0;

const AtomicString& autocomplete = element->getAttribute(autocompleteString);

@@ -2536,10 +2536,10 @@ int WebViewImpl::textInputFlags()

if (isHTMLTextFormControlElement(element)) {

HTMLTextFormControlElement* formElement = static_cast<HTMLTextFormControlElement*>(element);

if (formElement->supportsAutocapitalize()) {

- DEFINE_STATIC_LOCAL(const AtomicString, none, ("none", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, characters, ("characters", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, words, ("words", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, sentences, ("sentences", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, none, ("none"));

+ DEFINE_STATIC_LOCAL(const AtomicString, characters, ("characters"));

+ DEFINE_STATIC_LOCAL(const AtomicString, words, ("words"));

+ DEFINE_STATIC_LOCAL(const AtomicString, sentences, ("sentences"));

const AtomicString& autocapitalize = formElement->autocapitalize();

if (autocapitalize == none)