third_party/WebKit/Source/platform/network/HTTPParsers.cpp - Issue 1844223002: Literal AtomicString construction can rely on strlen optimization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/network/HTTPParsers.cpp

Issue 1844223002: Literal AtomicString construction can rely on strlen optimization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp ('k') | third_party/WebKit/Source/platform/network/HTTPParsersTest.cpp » ('j') | third_party/WebKit/Source/wtf/text/AtomicString.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/network/HTTPParsers.cpp

diff --git a/third_party/WebKit/Source/platform/network/HTTPParsers.cpp b/third_party/WebKit/Source/platform/network/HTTPParsers.cpp

index a61499db89d9f23ac1776fa3ec30ca29aa844c1f..64cf6fd34458cf0d71e8243bf8822014581c2da5 100644

--- a/third_party/WebKit/Source/platform/network/HTTPParsers.cpp

+++ b/third_party/WebKit/Source/platform/network/HTTPParsers.cpp

@@ -640,11 +640,11 @@ CacheControlHeader parseCacheControlDirectives(const AtomicString& cacheControlV

cacheControlHeader.maxAge = std::numeric_limits<double>::quiet_NaN();

cacheControlHeader.staleWhileRevalidate = std::numeric_limits<double>::quiet_NaN();

- DEFINE_STATIC_LOCAL(const AtomicString, noCacheDirective, ("no-cache", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, noStoreDirective, ("no-store", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, mustRevalidateDirective, ("must-revalidate", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, maxAgeDirective, ("max-age", AtomicString::ConstructFromLiteral));

- DEFINE_STATIC_LOCAL(const AtomicString, staleWhileRevalidateDirective, ("stale-while-revalidate", AtomicString::ConstructFromLiteral));

+ DEFINE_STATIC_LOCAL(const AtomicString, noCacheDirective, ("no-cache"));

+ DEFINE_STATIC_LOCAL(const AtomicString, noStoreDirective, ("no-store"));

+ DEFINE_STATIC_LOCAL(const AtomicString, mustRevalidateDirective, ("must-revalidate"));

+ DEFINE_STATIC_LOCAL(const AtomicString, maxAgeDirective, ("max-age"));

+ DEFINE_STATIC_LOCAL(const AtomicString, staleWhileRevalidateDirective, ("stale-while-revalidate"));

if (!cacheControlValue.isEmpty()) {

Vector<std::pair<String, String>> directives;